Subject: Re: [PATCH net-next v2 8/9] net: ipmr: rearrange and cleanup setsockopt

From: Nikolay Aleksandrov <[email-masked]>
Date: Mon, 23 Nov 2015 11:49:02 +0100

On 11/23/2015 06:44 AM, Cong Wang wrote:
> On Sat, Nov 21, 2015 at 6:57 AM, Nikolay Aleksandrov
> <[email-masked]> wrote:
>>  net/ipv4/ipmr.c | 191 +++++++++++++++++++++++++++++++-------------------------
>>  1 file changed, 107 insertions(+), 84 deletions(-)
> 
> Does this really simplify the code? :-/
> 
Did I really say it does ? :-) Now, to the point it just makes it
much easier to reason about this setsockopt which was doing conditional
locking in some of the cases before, and some were left out, also "v"
was sometimes signed and sometimes unsigned, it's clearer now which type
is used. I've left a comment why the only special case needs to unlock
rtnl (MRT_DONE).