Subject: Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

From: Daniel Wagner <[email-masked]>
Date: Mon, 23 Nov 2015 13:43:01 +0100

Hi Tejun,

On 11/21/2015 05:14 PM, Tejun Heo wrote:> +static int
> cgroup_mt_check_v1(const struct xt_mtchk_param *par)
> +{
> +	struct xt_cgroup_info_v1 *info = par->matchinfo;
> +	struct cgroup *cgrp;
> +
> +	if ((info->invert_path & ~1) || (info->invert_classid & ~1))
> +		return -EINVAL;

The checks below use pr_info() in case the configuration is not valid.
Is this missing here on purpose?

I have tested it slightly and it seems to work (also on an older
kernel). I don't know if that qualifies it for a Tested-by but at least
Acked-by should do the trick:

Tested-by: Daniel Wagner <[email-masked]>
Acked-by: Daniel Wagner <[email-masked]>

cheers,
daniel