public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Ying Xue <ying.xue@windriver•com>
To: David Miller <davem@davemloft•net>
Cc: jon.maloy@ericsson•com, stephen@networkplumber•org,
	tipc-discussion@lists•sourceforge.net, scan-admin@coverity•com,
	netdev@vger•kernel.org
Subject: Re: [PATCH] tipc: fix error handling of expanding buffer headroom
Date: Tue, 24 Nov 2015 13:33:16 +0800	[thread overview]
Message-ID: <5653F69C.4060406@windriver.com> (raw)
In-Reply-To: <20151123.233547.446739112661995737.davem@davemloft.net>

On 11/24/2015 12:35 PM, David Miller wrote:
> pskb_expand_head() returns negative error codes, therefore zero means
> success and therefore this "!err" check is reversed.

Thank you for pointing out such a stupid mistake I made.

I will send v2 to correct it.

Regards,
Ying


------------------------------------------------------------------------------
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140

      reply	other threads:[~2015-11-24  5:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-22  7:38 [PATCH] tipc: fix error handling of expanding buffer headroom Ying Xue
2015-11-24  4:35 ` David Miller
2015-11-24  5:33   ` Ying Xue [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5653F69C.4060406@windriver.com \
    --to=ying.xue@windriver$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=jon.maloy@ericsson$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=scan-admin@coverity$(echo .)com \
    --cc=stephen@networkplumber$(echo .)org \
    --cc=tipc-discussion@lists$(echo .)sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox