Subject: Re: [PATCH net] ipv6: kill sk_dst_lock

From: YOSHIFUJI Hideaki <[email-masked]>
Date: Tue, 1 Dec 2015 10:44:39 +0900

Hi,

Eric Dumazet wrote:
> diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h
> index 2bfb2ad2fab1..877f682989b8 100644
> --- a/include/net/ip6_route.h
> +++ b/include/net/ip6_route.h
> @@ -133,27 +133,18 @@ void rt6_clean_tohost(struct net *net, struct in6_addr *gateway);
>  /*
>   *	Store a destination cache entry in a socket
>   */
> -static inline void __ip6_dst_store(struct sock *sk, struct dst_entry *dst,
> -				   const struct in6_addr *daddr,
> -				   const struct in6_addr *saddr)
> +static inline void ip6_dst_store(struct sock *sk, struct dst_entry *dst,
> +				 const struct in6_addr *daddr,
> +				 const struct in6_addr *saddr)
>  {
>  	struct ipv6_pinfo *np = inet6_sk(sk);
> -	struct rt6_info *rt = (struct rt6_info *) dst;
>  
> +	np->dst_cookie = rt6_get_cookie((struct rt6_info *)dst);
>  	sk_setup_caps(sk, dst);
>  	np->daddr_cache = daddr;
>  #ifdef CONFIG_IPV6_SUBTREES
>  	np->saddr_cache = saddr;
>  #endif
> -	np->dst_cookie = rt6_get_cookie(rt);
> -}
> -

I believe you do not have to change function inside, right?

-- 
Hideaki Yoshifuji <[email-masked]>
Technical Division, MIRACLE LINUX CORPORATION