From: roopa <roopa@cumulusnetworks•com>
To: David Miller <davem@davemloft•net>
Cc: dsa@cumulusnetworks•com, netdev@vger•kernel.org, shm@cumulusnetworks•com
Subject: Re: [PATCH net-next v2] net: Add fib rules at vrf device create
Date: Tue, 08 Dec 2015 21:17:51 -0800 [thread overview]
Message-ID: <5667B97F.2080407@cumulusnetworks.com> (raw)
In-Reply-To: <20151208.224100.1951416968376650648.davem@davemloft.net>
On 12/8/15, 7:41 PM, David Miller wrote:
> From: David Ahern <dsa@cumulusnetworks•com>
> Date: Tue, 8 Dec 2015 20:21:51 -0700
>
>> On 12/8/15 8:08 PM, David Ahern wrote:
>>> root@kenny-jessie2:~# ip ru add oif vrf-red lookup vrf-red
>>>
>>> root@kenny-jessie2:~# ip ru ls
>>> 0: from all lookup local
>>> 32759: from all oif vrf-red lookup vrf-red
>>> 32760: from all iif vrf-green lookup vrf-green
>>> 32761: from all oif vrf-green lookup vrf-green
>>> 32762: from all iif vrf-blue lookup vrf-blue
>>> 32763: from all oif vrf-blue lookup vrf-blue
>>> 32764: from all iif vrf-red lookup vrf-red
>>> 32765: from all oif vrf-red lookup vrf-red
>>> 32766: from all lookup main
>>> 32767: from all lookup default
>> d'oh. They don't fail in the sense of a user getting an error message
>> but they add duplicate entries. So, if I fix the duplicity (ie., don't
>> add a second one) would the patch be acceptable?
> No, people need to issue all the commands in order for the configuration
> to work in all kernels.
>
agreed. In which case, maybe the rules should not be added by default, but added only under a special vrf dev creation attribute or flag
(something like IFLA_VRF_AUTOCREATE_RULES ?)
next prev parent reply other threads:[~2015-12-09 5:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 20:48 [PATCH net-next v2] net: Add fib rules at vrf device create David Ahern
2015-12-09 2:44 ` David Miller
2015-12-09 3:08 ` David Ahern
2015-12-09 3:21 ` David Ahern
2015-12-09 3:41 ` David Miller
2015-12-09 5:17 ` roopa [this message]
2015-12-09 3:40 ` David Miller
2015-12-09 13:04 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5667B97F.2080407@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsa@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shm@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox