From: Tilman Schmidt <tilman@imap•cc>
To: One Thousand Gnomes <gnomes@lxorguk•ukuu.org.uk>,
Paul Bolle <pebolle@tiscali•nl>
Cc: netdev@vger•kernel.org, Peter Hurley <peter@hurleysoftware•com>,
Sasha Levin <sasha.levin@oracle•com>,
syzkaller@googlegroups•com, David Miller <davem@davemloft•net>,
Karsten Keil <isdn@linux-pingi•de>,
isdn4linux@listserv•isdn4linux.de,
gigaset307x-common@lists•sourceforge.net,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH 1/3] ser_gigaset: fix up NULL checks
Date: Wed, 9 Dec 2015 11:45:57 +0100 [thread overview]
Message-ID: <56680665.4000301@imap.cc> (raw)
In-Reply-To: <20151208221657.71fd0d71@lxorguk.ukuu.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
Am 08.12.2015 um 23:16 schrieb One Thousand Gnomes:
> The right fix as far as I can see is to remove the tests although
> WARN_ON() combined with your tty->ops change might be safer.
Feel free to submit a patch.
>> It's pretty obvious that this should have been part of commit
>> f34d7a5b7010 ("tty: The big operations rework"). That being said, these
>
> It ahould probably have been fixed around the same time or in one of the
> tty locking reviews, but drivers/isdn and net/irda weren't traditionally
> part of the general tty maintenance but handled separately/
Or just ignored.
>> test puzzle me. It's not obvious why they're needed. Ie, can the null
>> dereferences they try to catch really happen? But I can try to figure
>> out that in the future, if I ever feel the urge to do so. Anyhow:
>>
>> Acked-by: Paul Bolle <pebolle@tiscali•nl>
>
> Nacked-by: Alan Cox <alan@linux•intel.com>
So you feel it's better to maintain the current inconsistent state
created by commit f34d7a5b? Please elaborate.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-12-09 10:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 11:00 [PATCH 0/3] ser_gigaset fixes Tilman Schmidt
2015-12-08 11:00 ` [PATCH 3/3] ser_gigaset: remove unnecessary kfree() calls from release method Tilman Schmidt
2015-12-08 23:15 ` Paul Bolle
2015-12-08 11:00 ` [PATCH 2/3] ser_gigaset: fix deallocation of platform device structure Tilman Schmidt
2015-12-08 23:12 ` Paul Bolle
2015-12-09 11:10 ` Tilman Schmidt
2015-12-10 11:20 ` Paul Bolle
2015-12-10 14:04 ` Peter Hurley
2015-12-12 17:52 ` Tilman Schmidt
2015-12-08 11:00 ` [PATCH 1/3] ser_gigaset: fix up NULL checks Tilman Schmidt
2015-12-08 19:45 ` Paul Bolle
2015-12-08 22:16 ` One Thousand Gnomes
2015-12-09 10:45 ` Tilman Schmidt [this message]
2015-12-09 12:12 ` One Thousand Gnomes
2015-12-09 19:18 ` Paul Bolle
2015-12-10 11:31 ` [PATCH 0/3] ser_gigaset fixes Paul Bolle
2015-12-12 18:09 ` Tilman Schmidt
2015-12-12 18:32 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56680665.4000301@imap.cc \
--to=tilman@imap$(echo .)cc \
--cc=davem@davemloft$(echo .)net \
--cc=gigaset307x-common@lists$(echo .)sourceforge.net \
--cc=gnomes@lxorguk$(echo .)ukuu.org.uk \
--cc=isdn4linux@listserv$(echo .)isdn4linux.de \
--cc=isdn@linux-pingi$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pebolle@tiscali$(echo .)nl \
--cc=peter@hurleysoftware$(echo .)com \
--cc=sasha.levin@oracle$(echo .)com \
--cc=syzkaller@googlegroups$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox