From: David Ahern <dsa@cumulusnetworks•com>
To: netdev@vger•kernel.org
Cc: ja@ssi•bg
Subject: Re: [PATCH net] net: Flush local routes when device changes vrf association
Date: Thu, 10 Dec 2015 09:43:00 -0700 [thread overview]
Message-ID: <5669AB94.30706@cumulusnetworks.com> (raw)
In-Reply-To: <1449711308-35842-1-git-send-email-dsa@cumulusnetworks.com>
On 12/9/15 6:35 PM, David Ahern wrote:
> The VRF driver cycles netdevs when an interface is enslaved or released:
> the down event is used to flush neighbor and route tables and the up
> event (if the interface was already up) effectively moves local and
> connected routes to the proper table.
>
> As of 4f823defdd5b the local route is left hanging around after a link
> down, so when a netdev is moved from one VRF to another (or released
> from a VRF altogether) local routes are left in the wrong table.
>
> Fix by introducing a NETDEV_VRF_CHANGE event that can be used to trigger
> the flush of all routes, including local ones.
>
> Fixes: 4f823defdd5b ("ipv4: fix to not remove local route on link down")
> Cc: Julian Anastasov <ja@ssi•bg>
> Signed-off-by: David Ahern <dsa@cumulusnetworks•com>
At Nik's pushing I see that I can do this without adding a new netdev
event; the NETDEV_CHANGEUPPER can be used for this as well.
Please disregard this patch.
prev parent reply other threads:[~2015-12-10 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 1:35 [PATCH net] net: Flush local routes when device changes vrf association David Ahern
2015-12-10 16:43 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5669AB94.30706@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=ja@ssi$(echo .)bg \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox