Subject: Re: [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port

From: Or Gerlitz <[email-masked]>
Date: Tue, 15 Dec 2015 11:09:40 +0200

On 12/14/2015 12:05 PM, Andrzej Hajda wrote:
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>

Please add here

Fixes: fc48866f7 ('net/mlx4: Adapt code for N-Port VF')

> Signed-off-by: Andrzej Hajda <[email-masked]>

otherwise, Looks good

Acked-by: Or Gerlitz <[email-masked]>

Or.