From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Vladislav Yasevich <vyasevich@gmail•com>, netdev@vger•kernel.org
Cc: Patrick McHardy <kaber@trash•net>
Subject: Re: [PATCH net] skbuff: Fix offset error in skb_reorder_vlan_header
Date: Tue, 15 Dec 2015 15:57:44 +0100 [thread overview]
Message-ID: <56702A68.8000600@6wind.com> (raw)
In-Reply-To: <1450133050-24636-1-git-send-email-vyasevich@gmail.com>
Le 14/12/2015 23:44, Vladislav Yasevich a écrit :
> skb_reorder_vlan_header is called after the vlan header has
> been pulled. As a result the offset of the begining of
> the mac header has been incrased by 4 bytes (VLAN_HLEN).
> When moving the mac addresses, include this incrase in
> the offset calcualation so that the mac addresses are
> copied correctly.
>
> Fixes: a6e18ff1117 (vlan: Fix untag operations of stacked vlans with REORDER_HEADER off)
> CC: Nicolas Dichtel <nicolas.dichtel@6wind•com>
> CC: Patrick McHardy <kaber@trash•net>
> Signed-off-by: Vladislav Yasevich <vyasevich@gmail•com>
Thank you for the fix. A bit late, but for the record:
Tested-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
next prev parent reply other threads:[~2015-12-15 14:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 20:43 [PATCH 0/2] Fix issues with vlans without REORDER_HEADER Vladislav Yasevich
2015-11-16 20:43 ` [PATCH 1/2] vlan: Fix untag operations of stacked vlans with REORDER_HEADER off Vladislav Yasevich
2015-12-14 14:51 ` Nicolas Dichtel
2015-12-14 22:44 ` [PATCH net] skbuff: Fix offset error in skb_reorder_vlan_header Vladislav Yasevich
2015-12-15 5:31 ` David Miller
2015-12-15 14:57 ` Nicolas Dichtel [this message]
2015-11-16 20:43 ` [PATCH 2/2] vlan: Do not put vlan headers back on bridge and macvlan ports Vladislav Yasevich
2015-11-17 19:39 ` [PATCH 0/2] Fix issues with vlans without REORDER_HEADER David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56702A68.8000600@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vyasevich@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox