Subject: Re: Commit-8b63ec18 breaks setting PHY pad-skew settings

From: Florian Fainelli <[email-masked]>
Date: Mon, 21 Dec 2015 11:50:32 -0800

On 21/12/15 02:40, Roosen Henri wrote:
> Hi David,
> 
> Unfortunately Linux kernel commit-8b63ec1837fa4c1ea604b278d201454eb3b85066 breaks setting pad-skew settings for Micrel PHY's.
> 
> Please see Documentation/devicetree/bindings/net/micrel-ksz90x1.txt: at the examples, it proposes to do PHY pad skew settings at the Ethernet device for autodetected PHY's.
> 
> Multiple boards are using this at the devicetree files: see imx6qdl-nitrogen6x.dtsi, imx6qdl-sabrelite.dtsi, socfpga_arria5_socdk.dts, socfpga_cyclone5_socdk.dts and socfpga_cyclone5_sockit.dts. But of course there might be more users depending on this than the ones which have an in-kernel dts file.
> 
> The micrel.c file searches for the parent of its OpenFirmware node for the skew settings: see ksz9031_config_init(): of_node = dev->parent->of_node; I don't think that was a clean implementation to start with.. But for sure it's incompatible with commit-8b63ec18, because the node of the Ethernet device which has the settings is not found anymore.
> 
> I'm not sure who to put on the copy list to discuss a proper solution, so feel free to get these persons and lists in the loop.

Usually, the best thing is to reply on the mailing-list directive, so
more people can jump in.

This particular issue is fixed with the following commit:

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=651df2183543bc92f5dbcf99cd9e236ead0bc4c5
-- 
Florian