From: Subash Abhinov Kasiviswanathan <subashab@codeaurora•org>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, fengguang.wu@intel•com,
netdev-owner@vger•kernel.org
Subject: Re: [PATCH net-next 1/1] net: rmnet_data: Initial implementation
Date: Wed, 08 Mar 2017 14:25:19 -0700 [thread overview]
Message-ID: <567a5c64abe80b82d58ef8c94f249848@codeaurora.org> (raw)
In-Reply-To: <20170307.121417.1835754162077665274.davem@davemloft.net>
> Inside the kernel you should use "u32", "u16", "u8", etc. for purely
> internal things, and for datastructures exported to userspace you
> should use "__u32", "__u16", "__u8".
>
> Furthermore, if the members have specific endianness you should
> properly use the "__le32", "__le16", "__be32", "__be16" etc. types.
>
>
> Please use netlink for device instantiation and configuration
> rather than ioctls.
Hi David
Thanks for reviewing. I'll post v2 with these changes.
prev parent reply other threads:[~2017-03-08 22:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 3:30 [PATCH net-next 0/1] net: Add support for rmnet_data driver Subash Abhinov Kasiviswanathan
2017-02-24 3:30 ` [PATCH net-next 1/1] net: rmnet_data: Initial implementation Subash Abhinov Kasiviswanathan
2017-03-07 20:14 ` David Miller
2017-03-08 21:25 ` Subash Abhinov Kasiviswanathan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567a5c64abe80b82d58ef8c94f249848@codeaurora.org \
--to=subashab@codeaurora$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=fengguang.wu@intel$(echo .)com \
--cc=netdev-owner@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox