Subject: Re: [PATCH v2 3/3] bpf: hash: use per-bucket spinlock

From: Daniel Borkmann <[email-masked]>
Date: Tue, 29 Dec 2015 17:27:07 +0100

On 12/29/2015 03:40 PM, Ming Lei wrote:
> Both htab_map_update_elem() and htab_map_delete_elem() can be
> called from eBPF program, and they may be in kernel hot path,
> so it isn't efficient to use a per-hashtable lock in this two
> helpers.
>
> The per-hashtable spinlock is used for protecting bucket's
> hlist, and per-bucket lock is just enough. This patch converts
> the per-hashtable lock into per-bucket spinlock, so that
> contention can be decreased a lot.
>
> Signed-off-by: Ming Lei <[email-masked]>

Looks better, thanks!

Acked-by: Daniel Borkmann <[email-masked]>