Subject: Re: [PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits

From: Jia-Ju Bai <[email-masked]>
Date: Tue, 05 Jan 2016 09:27:47 +0800

On 01/05/2016 12:50 AM, Helmut Schaa wrote:
> On Mon, Jan 4, 2016 at 8:55 AM, Jia-Ju Bai<[email-masked]>  wrote:
>> The driver calls pci_set_mwi to enable memory-write-invalidate when it
>> is initialized, but does not call pci_clear_mwi when it is removed. Many
>> other drivers calls pci_clear_mwi when pci_set_mwi is called, such as
>> r8169, 8139cp and e1000.
>>
>> This patch adds pci_clear_mwi in error handling and removal procedure,
>> which can fix the problem.
>>
>> Signed-off-by: Jia-Ju Bai<[email-masked]>
> Looks good to me.
> Does this fix any actual issue?
> If yes it might we worth to mention it in the commit message.
> Helmut
>

Lacking pci_clear_mwi may cause a resource-release omission,
but this omission may not cause obvious issues.
For reliability, it is better to add pci_clear_mwi in the driver.
Many other drivers do so, such as r8169, 8139cp and e1000.

Jia-Ju Bai