Subject: Re: [PATCH net-next] net, sched: add clsact qdisc

From: Hannes Frederic Sowa <[email-masked]>
Date: Thu, 7 Jan 2016 11:09:35 +0100

Hi Daniel and Alexei,

On 07.01.2016 04:53, Alexei Starovoitov wrote:
> On Wed, Jan 06, 2016 at 02:00:56AM +0100, Daniel Borkmann wrote:
>>
>> I decided to extend the sch_ingress module with clsact functionality so
>> that commonly used code can be reused, the module is being aliased with
>> sch_clsact so that it can be auto-loaded properly. Alternative would have been
>> to add a flag when initializing ingress to alter its behaviour plus aliasing
>> to a different name (as it's more than just ingress). However, the first would
>> end up, based on the flag, choosing the new/old behaviour by calling different
>> function implementations to handle each anyway, the latter would require to
>> register ingress qdisc once again under different alias. So, this really begs
>> to provide a minimal, cleaner approach to have Qdisc_ops and Qdisc_class_ops
>> by its own that share callbacks used by both.
> ...
>> Signed-off-by: Daniel Borkmann <[email-masked]>
>
> we've been going back and forth on the design and this final approach
> presented seems to be the best, since pros outweigh the cons.
>
> Acked-by: Alexei Starovoitov <[email-masked]>

One question:

With the advance in lockless qdiscs by John Fastabend, is it possible to 
push the handle_egress hook further down into sched layer?

Bye,
Hannes