From: Florian Fainelli <f.fainelli@gmail•com>
To: Andrew Lunn <andrew@lunn•ch>, David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCHv2 net-next 00/22] Support MDIO devices
Date: Thu, 07 Jan 2016 14:53:22 -0800 [thread overview]
Message-ID: <568EEC62.1080304@gmail.com> (raw)
In-Reply-To: <20160107201434.GD1356@lunn.ch>
On 07/01/16 12:14, Andrew Lunn wrote:
> On Thu, Jan 07, 2016 at 02:33:57PM -0500, David Miller wrote:
>> From: Andrew Lunn <andrew@lunn•ch>
>> Date: Wed, 6 Jan 2016 20:11:05 +0100
>>
>>> The discussions about changing the way DSA probes switches resulted in
>>> the wish to have switches attached to an MDIO bus to be represented as
>>> an MDIO device. However the current code only supports PHYs on MDIO
>>> busses. This patchset remedies this problem. It consists of a number
>>> of cleanups, abstraction for accessing structure members, and
>>> refactoring, as well as adding the concept of a generic MDIO device
>>> and MDIO driver.
>>>
>>> v2:
>>> Added Reviewed-by from Florian
>>> Made phydev_name() an inline function
>>> Added phy_attached_info/phy_attached_print() for information about
>>> the attached phy.
>>> Removed now redundant irq setup from of_mdio.c
>>> Dropped hunks from PHYMII ioctl which prevented access to any address
>>> DSA carrier off before phy setup
>>
>> Series applied, thanks Andrew.
>
> Hi Dave
>
> You might get some build failures from less well used
> architectures/drivers. I've got a couple of 0-day emails i need to
> send fixups for.
Just for completeness, I boot tested this on a BCM7445 (bcm_sf2 +
bcm7xxx PHY driver + mdio-bcm-unimac) and this worked like a charm, thanks!
[ 1.218140] Distributed Switch Architecture driver version 0.1
[ 1.224051] brcm-systemport f04a0000.ethernet eth0: [0]: detected a
Broadcom Starfighter 2 switch
[ 1.233159] Starfighter 2 top: 4.00, core: 2.00 base: 0xf0c00000,
IRQs: 65, 66
[ 1.240874] libphy: dsa slave smi: probed
[ 1.302102] f0b403c0.mdio:05: Broadcom BCM7445 PHY revision: 0xd0,
patch: 3
[ 1.616888] Broadcom BCM7445 f0b403c0.mdio:05: attached PHY driver
[Broadcom BCM7445] (mii_bus:phy_addr=f0b403c0.mdio:05, irq=-1)
[ 1.681215] Generic PHY dsa-0:00:00: attached PHY driver [Generic
PHY] (mii_bus:phy_addr=dsa-0:00:00, irq=-1)
[ 1.744103] Generic PHY fixed-0:01: attached PHY driver [Generic PHY]
(mii_bus:phy_addr=fixed-0:01, irq=-1)
[ 1.807103] Generic PHY fixed-0:02: attached PHY driver [Generic PHY]
(mii_bus:phy_addr=fixed-0:02, irq=-1)
--
Florian
prev parent reply other threads:[~2016-01-07 22:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 19:11 [PATCHv2 net-next 00/22] Support MDIO devices Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 01/22] phy: Consistently use addr for address on an MII bus Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 02/22] mdio: Move mdiobus_read/write operatings into mdio.h Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 03/22] phy: Use phy_read() instead of mdiobus_read() Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 04/22] phy: Add phydev_err() and phydev_dbg() macros Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 05/22] phy: add phydev_name() wrapper Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 06/22] net: dnet: Use phy_find_first() helper Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 07/22] phy: phy_{read|write}_mmd_indirect: get addr from phydev Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 08/22] phy: Centralise print about attached phy Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 09/22] phy: mdio-octeon: Use devm_mdiobus_alloc_size() Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 10/22] mdio: Move allocation of interrupts into core Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 11/22] phy: Add an mdio_device structure Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 12/22] of: phy: Only register a phy device for phys Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 13/22] phy: Add API for {un}registering an mdio device to a bus Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 14/22] phy_device: Move phy attributes into phy_device Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 15/22] dsa: Register netdev before phy Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 16/22] phy: Move PHY PM operations into phy_device Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 17/22] phy: Centralize setting driver module owner Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 18/22] phy: Move phy specific bus match into phy_device Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 19/22] mdio_bus: Generalise of_mdiobus_link_phydev() Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 20/22] mdio_bus: Add comment to mdiobus_scan() and __mdiobus_register() Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 21/22] mdio: Add support for mdio drivers Andrew Lunn
2016-01-06 19:11 ` [PATCHv2 net-next 22/22] mdio: Abstract device_remove() and device_free() Andrew Lunn
2016-01-07 19:33 ` [PATCHv2 net-next 00/22] Support MDIO devices David Miller
2016-01-07 20:14 ` Andrew Lunn
2016-01-07 21:30 ` David Miller
2016-01-07 22:53 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568EEC62.1080304@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox