From: Hans Westgaard Ry <hans.westgaard.ry@oracle•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Alexey Kuznetsov <kuznet@ms2•inr.ac.ru>,
James Morris <jmorris@namei•org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>,
Patrick McHardy <kaber@trash•net>,
Alexei Starovoitov <ast@plumgrid•com>,
Jiri Pirko <jiri@mellanox•com>,
Eric Dumazet <edumazet@google•com>,
Daniel Borkmann <daniel@iogearbox•net>,
Nicolas Dichtel <nicolas.dichtel@6wind•com>,
"Eric W. Biederman " <ebiederm@xmission•com>,
Salam Noureddine <noureddine@arista•com>,
Jarod Wilson <jarod@redhat•com>,
Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>,
Julian Anastasov <ja@ssi•bg>, Ying Xue <ying.xue@windriver•com>,
Craig Gallek <kraig@google•com>,
Mel Gorman <mgorman@techsingularity•net>,
"\" hannes\"@stressinduktion.org " <hannes@stressinduktion•org>,
Edward Jee <edjee@google•com>,
Julia Lawall <julia.lawall@lip6•fr>,
netdev@vger•kernel.org, linux-kernel@vger•ke
Subject: Re: [PATCH] net: add per device sg_max_frags for skb
Date: Fri, 8 Jan 2016 11:01:49 +0100 [thread overview]
Message-ID: <568F890D.70004@oracle.com> (raw)
In-Reply-To: <1452089115.8255.171.camel@edumazet-glaptop2.roam.corp.google.com>
On 01/06/2016 03:05 PM, Eric Dumazet wrote:
> On Wed, 2016-01-06 at 14:16 +0100, Hans Westgaard Ry wrote:
>> Devices may have limits on the number of fragments in an skb they
>> support. Current codebase uses a constant as maximum for number of
>> fragments (MAX_SKB_FRAGS) one skb can hold and use.
>>
>> When enabling scatter/gather and running traffic with many small
>> messages the codebase uses the maximum number of fragments and thereby
>> violates the max for certain devices.
>>
>> An example of such a violation is when running IPoIB on a HCA
>> supporting 16 SGE on an architecture with 4K pagesize. The
>> MAX_SKB_FRAGS will be 17 (64K/4K+1) and because IPoIB adds yet another
>> segment we end up with send_requests with 18 SGE resulting in
>> kernel-panic.
>>
>> The patch allows the device to limit the maximum number fragments used
>> in one skb.
>>
>> The functionality corresponds to gso_max_size/gso_max_segs for gso.
> Unfortunately this is not the right place to fix this issue.
>
> Think about forwarding workloads, where the SKB is cooked by GRO engine.
>
> Anyway, local TCP stack uses 32KB page fragments, so typical skb has no
> more than 3 frags.
>
> Look at ndo_features_check(), where the problematic device driver can
> add its logic.
>
>
>
I've had a look at ndo_features_check and understand that I could supply
my own
version of the routine, but I wasn't able to figure out how that would
solve my problem.
As far as I can see the routine is not called in the part of code
handling scatter/gather.
Could you help out with more info?
Hans
prev parent reply other threads:[~2016-01-08 10:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 13:16 [PATCH] net: add per device sg_max_frags for skb Hans Westgaard Ry
2016-01-06 13:59 ` David Laight
2016-01-08 9:55 ` Hans Westgaard Ry
2016-01-08 10:33 ` David Laight
2016-01-08 11:47 ` Hannes Frederic Sowa
2016-01-13 13:57 ` Hans Westgaard Ry
2016-01-13 14:19 ` Eric Dumazet
2016-01-13 14:20 ` Eric Dumazet
2016-01-13 15:07 ` Hannes Frederic Sowa
2016-01-13 15:38 ` David Miller
2016-01-13 15:44 ` Eric Dumazet
2016-01-13 21:07 ` Eric W. Biederman
2016-01-27 13:20 ` [PATCH v2] net:Add sysctl_tcp_sg_max_skb_frags Hans Westgaard Ry
2016-01-27 15:15 ` Eric Dumazet
2016-01-27 18:12 ` Hannes Frederic Sowa
2016-02-01 13:12 ` Hans Westgaard Ry
2016-01-27 20:13 ` David Miller
2016-02-03 8:26 ` [PATCH v3] net:Add sysctl_max_skb_frags Hans Westgaard Ry
2016-02-03 11:25 ` Herbert Xu
2016-02-03 11:36 ` Hannes Frederic Sowa
2016-02-03 12:20 ` Herbert Xu
2016-02-03 14:03 ` Hannes Frederic Sowa
2016-02-03 14:30 ` Eric Dumazet
2016-02-03 17:36 ` David Laight
2016-02-03 15:58 ` Alexander Duyck
2016-02-03 16:07 ` Eric Dumazet
2016-02-03 17:43 ` Alexander Duyck
2016-02-03 17:54 ` Eric Dumazet
2016-02-03 18:24 ` Alexander Duyck
2016-02-03 19:23 ` Eric Dumazet
2016-02-03 21:03 ` Alexander Duyck
2016-02-09 9:30 ` David Miller
2016-01-06 14:05 ` [PATCH] net: add per device sg_max_frags for skb Eric Dumazet
2016-01-08 10:01 ` Hans Westgaard Ry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568F890D.70004@oracle.com \
--to=hans.westgaard.ry@oracle$(echo .)com \
--cc=ast@plumgrid$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=edjee@google$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=hannes@stressinduktion$(echo .)org \
--cc=ja@ssi$(echo .)bg \
--cc=jarod@redhat$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=julia.lawall@lip6$(echo .)fr \
--cc=kaber@trash$(echo .)net \
--cc=kraig@google$(echo .)com \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux-kernel@vger$(echo .)ke \
--cc=makita.toshiaki@lab$(echo .)ntt.co.jp \
--cc=mgorman@techsingularity$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=noureddine@arista$(echo .)com \
--cc=ying.xue@windriver$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox