From: Hannes Frederic Sowa <hannes@stressinduktion•org>
To: Tom Herbert <tom@herbertland•com>
Cc: Linux Kernel Network Developers <netdev@vger•kernel.org>,
Jesse Gross <jesse@kernel•org>
Subject: Re: [PATCH net-next v4 06/10] netdev: add netdevice notifier type to trigger a reprogramming of offloads
Date: Sat, 9 Jan 2016 18:30:07 +0100 [thread overview]
Message-ID: <5691439F.5090500@stressinduktion.org> (raw)
In-Reply-To: <CALx6S357fYzhCRHsPAjX+NH+5Wc1tnUuNwcZ5oy3WiAMASjOEA@mail.gmail.com>
On 09.01.2016 18:25, Tom Herbert wrote:
> On Sat, Jan 9, 2016 at 7:07 AM, Hannes Frederic Sowa
> <hannes@stressinduktion•org> wrote:
>> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion•org>
>> ---
>> include/linux/netdevice.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>> index 8d8e5ca951b493..9750e46760695d 100644
>> --- a/include/linux/netdevice.h
>> +++ b/include/linux/netdevice.h
>> @@ -2183,6 +2183,7 @@ struct netdev_lag_lower_state_info {
>> #define NETDEV_BONDING_INFO 0x0019
>> #define NETDEV_PRECHANGEUPPER 0x001A
>> #define NETDEV_CHANGELOWERSTATE 0x001B
>> +#define NETDEV_REFRESH_OFFLOADS 0x001C
>>
> Per previous discussion we don't want to generalize this current
> offload interface. Can we just NETDEV_UP as the notifier?
The problem with only using NETDEV_UP/REGISTER is that some drivers need
to reconfigure their offloads during operation while keeping the
netdevice in UP state. One example is ixgbe. This was my first idea also.
I am fine with both approaches, my initial submission had two types to
notify geneve and vxlan so their doesn't happen any "cross-over".
Bye,
Hannes
next prev parent reply other threads:[~2016-01-09 17:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 15:07 [PATCH net-next v4 00/10] net: break dependency of drivers on geneve and vxlan Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 01/10] qlcnic: protect qlcnic_82xx_io_slot_reset with rtnl lock Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 02/10] mlx4: add rtnl lock protection in mlx4_en_restart Hannes Frederic Sowa
2016-01-11 12:12 ` Eugenia Emantayev
2016-01-09 15:07 ` [PATCH net-next v4 03/10] ixgbe: add rtnl locking in service task around vxlan_get_rx_port Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 04/10] benet: add rtnl lock protection around be_open in be_resume Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 05/10] fm10k: add rtnl lock protection in fm10k_io_resume Hannes Frederic Sowa
2016-01-09 21:51 ` Florian Westphal
2016-01-09 22:44 ` Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 06/10] netdev: add netdevice notifier type to trigger a reprogramming of offloads Hannes Frederic Sowa
2016-01-09 17:25 ` Tom Herbert
2016-01-09 17:30 ` Hannes Frederic Sowa [this message]
2016-01-09 22:27 ` Tom Herbert
2016-01-09 22:52 ` Hannes Frederic Sowa
[not found] ` <CALx6S341SP0XN-iBGeR_MXyu3LoYmXBsCBguDcwc26CVvF3Gtw@mail.gmail.com>
2016-01-11 12:11 ` Hannes Frederic Sowa
2016-01-11 16:09 ` Tom Herbert
2016-01-11 18:56 ` Hannes Frederic Sowa
2016-01-11 20:46 ` Tom Herbert
2016-01-11 21:09 ` Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 07/10] vxlan: break dependency to network drivers Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 08/10] geneve: " Hannes Frederic Sowa
2016-01-09 21:59 ` Jesse Gross
2016-01-09 15:07 ` [PATCH net-next v4 09/10] net: harmonize vxlan_get_rx_port and geneve_get_rx_port to netdev_refresh_offloads Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 10/10] netdev: update comments and explain idempotency and rtnl locking Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5691439F.5090500@stressinduktion.org \
--to=hannes@stressinduktion$(echo .)org \
--cc=jesse@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tom@herbertland$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox