From: "Yankejian (Hackim Yim)" <yankejian@huawei•com>
To: Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Yisen Zhuang <Yisen.zhuang@huawei•com>, <davem@davemloft•net>,
<robh+dt@kernel•org>, <pawel.moll@arm•com>,
<mark.rutland@arm•com>, <ijc+devicetree@hellion•org.uk>,
<galak@codeaurora•org>, <catalin.marinas@arm•com>,
<will.deacon@arm•com>, <huangdaode@hisilicon•com>,
<liguozhu@huawei•com>, <arnd@arndb•de>, <fengguang.wu@intel•com>,
<salil.mehta@huawei•com>, <lisheng011@huawei•com>
Cc: <devicetree@vger•kernel.org>, <netdev@vger•kernel.org>,
<linuxarm@huawei•com>, <linux-kernel@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH v2 next-next] net: hns: enet specifies a reference to dsaf
Date: Wed, 20 Jan 2016 19:10:19 +0800 [thread overview]
Message-ID: <569F6B1B.6080902@huawei.com> (raw)
In-Reply-To: <1453282570.2521.130.camel@linux.intel.com>
On 2016/1/20 17:36, Andy Shevchenko wrote:
> On Wed, 2016-01-20 at 14:49 +0800, Yankejian (Hackim Yim) wrote:
>>>> +
>>>>>>> + snprintf(ae_dev->name, AE_NAME_SIZE, "%s%d",
>>>>>>> DSAF_DEVICE_NAME,
>>>>>>> + (int)atomic_inc_return(&id));
>>> If you bind/unbind device enough times you may get an overflow and
>>> end
>>> up with name of existing device (if you have 1+ of them in the
>>> system).
>>>
>>> To avoid such situation better to use IDA/IDR framework.
>>>
>> Hi, Andy
>> Thanks again for your suggestion.
>> It seems that using IDA/IDR framework is better, but all of the
>> functions must be serialized by lock.
> AFAIR it's designed in a way you don't need to do any additional
> locking or synchronization.
really? if so, that is great.
could you sent me an example.
thanks very much. Andy.
Best Regards,
Kejian Yan
next prev parent reply other threads:[~2016-01-20 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 3:14 [PATCH v2 next-next] net: hns: enet specifies a reference to dsaf Kejian Yan
2016-01-14 3:00 ` Yisen Zhuang
[not found] ` <56970F48.9060504-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-01-14 9:43 ` Andy Shevchenko
[not found] ` <1452764635.2521.28.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-01-18 11:35 ` Yankejian (Hackim Yim)
[not found] ` <569F2DEC.9040209@huawei.com>
[not found] ` <569F2DEC.9040209-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-01-20 9:36 ` Andy Shevchenko
2016-01-20 11:10 ` Yankejian (Hackim Yim) [this message]
[not found] ` <1452654880-28980-1-git-send-email-yankejian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-01-15 2:28 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2016-01-13 3:01 Kejian Yan
2016-01-13 2:52 ` Yankejian (Hackim Yim)
2016-01-13 2:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569F6B1B.6080902@huawei.com \
--to=yankejian@huawei$(echo .)com \
--cc=Yisen.zhuang@huawei$(echo .)com \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=arnd@arndb$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=fengguang.wu@intel$(echo .)com \
--cc=galak@codeaurora$(echo .)org \
--cc=huangdaode@hisilicon$(echo .)com \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=liguozhu@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxarm@huawei$(echo .)com \
--cc=lisheng011@huawei$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pawel.moll@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=salil.mehta@huawei$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox