Subject: Re: [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE_INTERRUPTS

From: Florian Fainelli <[email-masked]>
Date: Wed, 20 Jan 2016 13:29:50 -0800

Le 20/01/2016 13:20, [email-masked] a écrit :
>>> Targetting the "net" tree since these are bugfixes, but I would like
>>> Woojun and Andrew to take a look and test that on their respective
>>> HW setups as well.
>>
>> Ok I'll wait for Woojun and Andrew to give feedback.
> 
> This patch fixes periodic phy read_status access when phy is configured as PHY_IGNORE_INTERRUPTS.

Great, thanks for the feedback!

> Tested and confirmed with LAN78xx USB-to-Ethernet driver except following checkpatch.pl warnings.
> 
> WARNING: line over 80 characters
> #54: FILE: drivers/net/phy/phy.c:1008:
> +		queue_delayed_work(system_power_efficient_wq, &phydev->state_queue,

This one is definitively added by the patch

> 
> WARNING: Comparisons should place the constant on the right side of the test
> #68: FILE: drivers/net/phy/phy.c:714:
> +		if (PHY_HALTED != phydev->state &&
> 

This one is an existing warning.

David, let me know if you consider the over 80 columns issue worth a
resubmission or not, either way is fine with me.

Thanks!
-- 
Florian