From: Shuah Khan <shuahkh@osg•samsung.com>
To: "Jεan Sacren" <sakiwit@gmail•com>,
"David Miller" <davem@davemloft•net>,
siva.kallam@broadcom•com
Cc: julia.lawall@lip6•fr, shuahkhan@gmail•com, bh74.an@samsung•com,
ks.giri@samsung•com, vipul.pandya@samsung•com,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: question about samsung/sxgbe/sxgbe_xpcs.c
Date: Thu, 21 Jan 2016 07:04:17 -0700 [thread overview]
Message-ID: <56A0E561.2030409@osg.samsung.com> (raw)
In-Reply-To: <20160121051056.GA4373@mail.gmail.com>
On 01/20/2016 10:10 PM, Jεan Sacren wrote:
> From: David Miller <davem@davemloft•net>
> Date: Tue, 19 Jan 2016 14:36:28 -0500
>>
>> From: Julia Lawall <julia.lawall@lip6•fr>
>> Date: Tue, 19 Jan 2016 19:54:20 +0100 (CET)
>
> [...]
>
>>> I just wondered. I was looking at dependencies between networking files.
>>> This one stands out because nothing is dependenton it, even the files it
>>> is compiled with, and it doesn't contain the usual functions,
>>> register_netdev, etc.
>>
>> Even with that explanation, this is a bogus situation.
>>
>> There are no in-tree callers of this code. It should be removed until there
>> are in-tree users.
>>
>> Nobody can figure out if the interface for this is done properly without seeing
>> the call sites and how they work. It is therefore impossible to review this
>> code and judge it's design.
>>
>> If someone doesn't send me a removal patch, I will remove this code myself.
>
> I have the patch ready.
>
> Do you want me to submit it now during the merge window or wait till
> net-next opens up again?
>
My second attempt to locate the author for a comment
on this before it gets removed. Maybe this code could
be fixed just in case it is important for some product
out there.
I am cc'ing the original author in case he has any
comments.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg•samsung.com | (970) 217-8978
next prev parent reply other threads:[~2016-01-21 14:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 16:26 question about samsung/sxgbe/sxgbe_xpcs.c Julia Lawall
2016-01-19 18:18 ` Shuah Khan
2016-01-19 18:54 ` Julia Lawall
2016-01-19 19:36 ` David Miller
2016-01-21 5:10 ` Jεan Sacren
2016-01-21 14:04 ` Shuah Khan [this message]
2016-01-21 19:09 ` David Miller
2016-01-21 18:45 ` David Miller
2016-01-21 19:32 ` Jεan Sacren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A0E561.2030409@osg.samsung.com \
--to=shuahkh@osg$(echo .)samsung.com \
--cc=bh74.an@samsung$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=julia.lawall@lip6$(echo .)fr \
--cc=ks.giri@samsung$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sakiwit@gmail$(echo .)com \
--cc=shuahkhan@gmail$(echo .)com \
--cc=siva.kallam@broadcom$(echo .)com \
--cc=vipul.pandya@samsung$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox