From: Nicolas Ferre <nicolas.ferre@atmel•com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail•com>
Cc: <linux-kernel@vger•kernel.org>, <netdev@vger•kernel.org>
Subject: Re: [PATCH 2/3] net: macb: fix build warning
Date: Mon, 25 Jan 2016 09:45:36 +0100 [thread overview]
Message-ID: <56A5E0B0.4070802@atmel.com> (raw)
In-Reply-To: <1453702389-601-1-git-send-email-sudipm.mukherjee@gmail.com>
Le 25/01/2016 07:13, Sudip Mukherjee a écrit :
> We are getting build warning about:
> macb.c:2889:13: warning: 'tx_clk' may be used uninitialized in this function
> macb.c:2888:11: warning: 'hclk' may be used uninitialized in this function
>
> In reality they are not used uninitialized as clk_init() will initialize
> them, this patch will just silence the warning.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia•org>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel•com>
Thanks for your patch.
Bye,
> ---
> drivers/net/ethernet/cadence/macb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 9d9984a..50c9410 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -2823,7 +2823,7 @@ static int macb_probe(struct platform_device *pdev)
> struct device_node *np = pdev->dev.of_node;
> struct device_node *phy_node;
> const struct macb_config *macb_config = NULL;
> - struct clk *pclk, *hclk, *tx_clk;
> + struct clk *pclk, *hclk = NULL, *tx_clk = NULL;
> unsigned int queue_mask, num_queues;
> struct macb_platform_data *pdata;
> bool native_io;
>
--
Nicolas Ferre
next prev parent reply other threads:[~2016-01-25 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 6:13 [PATCH 2/3] net: macb: fix build warning Sudip Mukherjee
2016-01-25 8:45 ` Nicolas Ferre [this message]
2016-01-25 18:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A5E0B0.4070802@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sudipm.mukherjee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox