From: Thomas Egerer <hakke_007@gmx•de>
To: Herbert Xu <herbert@gondor•apana.org.au>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV
Date: Mon, 25 Jan 2016 12:57:23 +0100 [thread overview]
Message-ID: <56A60DA3.2030501@gmx.de> (raw)
In-Reply-To: <20160125102659.GA6976@gondor.apana.org.au>
On 01/25/2016 11:26 AM, Herbert Xu wrote:
> Thomas Egerer <hakke_007@gmx•de> wrote:
>> The ESP algorithms using CBC mode require echainiv. Hence INET*_ESP have
>> to select CRYPTO_ECHAINIV in order to work properly. This solves the
>> issues caused by a misconfiguration as described in [1].
>> The original approach, patching crypto/Kconfig was turned down by
>> Herbert Xu [2].
>>
>> [1] https://lists.strongswan.org/pipermail/users/2015-December/009074.html
>> [2] http://marc.info/?l=linux-crypto-vger&m=145224655809562&w=2
>>
>> Signed-off-by: Thomas Egerer <hakke_007@gmx•de>
>> ---
>> net/ipv4/Kconfig | 1 +
>> net/ipv6/Kconfig | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
>> index c229205..7758247 100644
>> --- a/net/ipv4/Kconfig
>> +++ b/net/ipv4/Kconfig
>> @@ -353,6 +353,7 @@ config INET_ESP
>> select CRYPTO_CBC
>> select CRYPTO_SHA1
>> select CRYPTO_DES
>> + select CRYPTO_ECHAINIV
>> ---help---
>> Support for IPsec ESP.
>>
>> diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
>> index bb7dabe..40c8975 100644
>> --- a/net/ipv6/Kconfig
>> +++ b/net/ipv6/Kconfig
>> @@ -69,6 +69,7 @@ config INET6_ESP
>> select CRYPTO_CBC
>> select CRYPTO_SHA1
>> select CRYPTO_DES
>
> Your patch seems to be missing a few lines at the end.
That's odd, yet the my outbox contains a truncated mail, too.
Sorry, will resend the patch in a jiff.
Thomas
> Otherwise it looks good to me.
>
> Cheers,
>
next prev parent reply other threads:[~2016-01-25 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 13:30 [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV Thomas Egerer
2016-01-25 10:26 ` Herbert Xu
2016-01-25 11:57 ` Thomas Egerer [this message]
2016-01-25 11:58 ` Thomas Egerer
2016-01-25 13:56 ` Herbert Xu
2016-01-25 18:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A60DA3.2030501@gmx.de \
--to=hakke_007@gmx$(echo .)de \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox