From: Yuki Machida <machida.yuki@jp•fujitsu.com>
To: netdev@vger•kernel.org
Cc: gregkh@linuxfoundation•org, "Salva Peiró" <speirofr@gmail•com>,
"Hans Verkuil" <hans.verkuil@cisco•com>,
"Mauro Carvalho Chehab" <mchehab@osg•samsung.com>
Subject: Re: [PATCH 4.1] [media] media/vivid-osd: fix info leak in ioctl
Date: Tue, 26 Jan 2016 08:44:54 +0900 [thread overview]
Message-ID: <56A6B376.4010507@jp.fujitsu.com> (raw)
In-Reply-To: <1453718538-21691-1-git-send-email-machida.yuki@jp.fujitsu.com>
It has sent to the wrong Mainling List.
sorry.
On 2016年01月25日 19:42, Yuki Machida wrote:
> commit eda98796aff0d9bf41094b06811f5def3b4c333c upstream.
>
> The vivid_fb_ioctl() code fails to initialize the 16 _reserved bytes of
> struct fb_vblank after the ->hcount member. Add an explicit
> memset(0) before filling the structure to avoid the info leak.
>
> This fixes CVE-2015-7884.
>
> Signed-off-by: Salva Peiró <speirofr@gmail•com>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco•com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg•samsung.com>
> Signed-off-by: Yuki Machida <machida.yuki@jp•fujitsu.com>
> ---
> drivers/media/platform/vivid/vivid-osd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/vivid/vivid-osd.c b/drivers/media/platform/vivid/vivid-osd.c
> index 084d346..e15eef6 100644
> --- a/drivers/media/platform/vivid/vivid-osd.c
> +++ b/drivers/media/platform/vivid/vivid-osd.c
> @@ -85,6 +85,7 @@ static int vivid_fb_ioctl(struct fb_info *info, unsigned cmd, unsigned long arg)
> case FBIOGET_VBLANK: {
> struct fb_vblank vblank;
>
> + memset(&vblank, 0, sizeof(vblank));
> vblank.flags = FB_VBLANK_HAVE_COUNT | FB_VBLANK_HAVE_VCOUNT |
> FB_VBLANK_HAVE_VSYNC;
> vblank.count = 0;
>
prev parent reply other threads:[~2016-01-25 23:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 10:42 [PATCH 4.1] [media] media/vivid-osd: fix info leak in ioctl Yuki Machida
2016-01-25 17:18 ` Greg KH
2016-01-27 7:59 ` Yuki Machida
2016-01-25 23:44 ` Yuki Machida [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A6B376.4010507@jp.fujitsu.com \
--to=machida.yuki@jp$(echo .)fujitsu.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hans.verkuil@cisco$(echo .)com \
--cc=mchehab@osg$(echo .)samsung.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=speirofr@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox