From: David Ahern <dsa@cumulusnetworks•com>
To: Paolo Abeni <pabeni@redhat•com>, netdev@vger•kernel.org
Cc: "David S. Miller" <davem@davemloft•net>,
Hajime Tazaki <thehajime@gmail•com>,
lucien.xin@gmail•com,
Marcelo Ricardo Leitner <marcelo.leitner@gmail•com>
Subject: Re: [PATCH net 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()
Date: Thu, 28 Jan 2016 07:59:49 -0700 [thread overview]
Message-ID: <56AA2CE5.2050307@cumulusnetworks.com> (raw)
In-Reply-To: <88bb9789390b781edd13fc4bfaf9fec868f693dd.1453830778.git.pabeni@redhat.com>
On 1/27/16 6:45 AM, Paolo Abeni wrote:
> The current implementation of ip6_dst_lookup_tail() basically
> ignore the egress ifindex match: if the saddr is set,
> ip6_route_output() purposefully ignores flowi6_oif, due
> to the commit d46a9d678e4c ("net: ipv6: Dont add RT6_LOOKUP_F_IFACE
> flag if saddr set"), if the saddr is 'any' the first route lookup
> in ip6_dst_lookup_tail fails, but upon failure a second lookup will
> be performed with saddr set, thus ignoring the ifindex constraint.
>
> This commit adds an output route lookup function variant, which
> allows the caller to specify additional lookup flags, and modify
> ip6_dst_lookup_tail() to enforce the ifindex match on the second
> lookup via said helper.
>
> Fixes: d46a9d678e4c ("net: ipv6: Dont add RT6_LOOKUP_F_IFACE flag if saddr set")
> Signed-off-by: Paolo Abeni <pabeni@redhat•com>
I don't agree with that 'Fixes:' tag.
ip6_route_output did not add the RT6_LOOKUP_F_IFACE flag until
741a11d9e410; d46a9d678e4c is a follow on to limit adding the flag only
if no source address is given.
Since ip6_dst_lookup_tail never considered the flowi6_oif this is a
general bug fix rather than a fix of d46a9d678e4c.
next prev parent reply other threads:[~2016-01-28 14:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 13:45 [PATCH net 0/2] ipv6: fix sticky pktinfo behaviour Paolo Abeni
2016-01-27 13:45 ` [PATCH net 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail() Paolo Abeni
2016-01-27 18:38 ` Hannes Frederic Sowa
2016-01-28 12:27 ` Paolo Abeni
2016-01-28 13:02 ` Hannes Frederic Sowa
2016-01-28 14:59 ` David Ahern [this message]
2016-01-28 17:04 ` Paolo Abeni
2016-01-27 13:45 ` [PATCH net 2/2] ipv6/udp: use sticky pktinfo egress ifindex on connect() Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA2CE5.2050307@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=lucien.xin@gmail$(echo .)com \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=thehajime@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox