From: Kevin Smith <kevin.smith@elecsyscorp•com>
To: Andrew Lunn <andrew@lunn•ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"kernel@savoirfairelinux•com" <kernel@savoirfairelinux•com>,
"David S. Miller" <davem@davemloft•net>,
Russell King <rmk+kernel@arm•linux.org.uk>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: fix port VLAN maps
Date: Fri, 29 Jan 2016 15:14:59 +0000 [thread overview]
Message-ID: <56AB81F4.6050409@elecsyscorp.com> (raw)
In-Reply-To: <20160129021832.GA12692@lunn.ch>
On 01/28/2016 08:18 PM, Andrew Lunn wrote:
> On Thu, Jan 28, 2016 at 04:54:37PM -0500, Vivien Didelot wrote:
>> Currently the port based VLAN maps should be configured to allow every
>> port to egress frames on all other ports, except themselves.
>>
>> The debugfs interface shows that they are misconfigured. For instance, a
>> 7-port switch has the following content in the related register 0x06:
>>
>> GLOBAL GLOBAL2 SERDES 0 1 2 3 4 5 6
>> ...
>> 6: 1fa4 1f0f 4 7f 7e 7d 7c 7b 7a 79
>> ...
>>
>> This means that port 3 is allowed to talk to port 2-6, but cannot talk
>> to ports 0 and 1. With this fix, port 3 can correctly talk to all ports
>> except 3 itself:
>>
>> GLOBAL GLOBAL2 SERDES 0 1 2 3 4 5 6
>> ...
>> 6: 1fa4 1f0f 4 7e 7d 7b 77 6f 5f 3f
>> ...
>>
>> Fixes: ede8098d0fef ("net: dsa: mv88e6xxx: bridges do not need an FID")
>> Reported-by: Kevin Smith <kevin.smith@elecsyscorp•com>
>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux•com>
> Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Tested-by: Kevin Smith <kevin.smith@elecsyscorp•com>
next prev parent reply other threads:[~2016-01-29 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 21:54 [PATCH net] net: dsa: mv88e6xxx: fix port VLAN maps Vivien Didelot
2016-01-29 2:18 ` Andrew Lunn
2016-01-29 15:14 ` Kevin Smith [this message]
2016-01-30 3:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AB81F4.6050409@elecsyscorp.com \
--to=kevin.smith@elecsyscorp$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=kernel@savoirfairelinux$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rmk+kernel@arm$(echo .)linux.org.uk \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox