From: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public•gmane.org>
To: Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public•gmane.org>
Cc: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public•gmane.org>,
Chaoming Li <chaoming_li-kXabqFNEczNtrwSWzY7KCg@public•gmane.org>,
Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
Linux Wireless List
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
Network Development
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]
Date: Fri, 29 Jan 2016 13:42:52 -0600 [thread overview]
Message-ID: <56ABC0BC.9010202@lwfinger.net> (raw)
In-Reply-To: <CA+55aFysqqp-BCZs1ue6_1tE=h9SOUZTH_o7TwGbsaBnaFvXGA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 01/29/2016 12:39 PM, Linus Torvalds wrote:
> On Fri, Jan 29, 2016 at 9:54 AM, Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public•gmane.org> wrote:
>>
>> The test patch that Johannes sent earlier was close. The section needed to
>> add VHT rates is:
>
> Hmm. This looks pretty much exactly like what I already tried (I had
> fixed Johannes' patch to use "vht_cap" already, since it didn't
> compile otherwise).
>
> So the only difference is that it only checks WIRELESS_MODE_AC_5G.
>
> But it worked for me this time. I have no idea why.
>
> Maybe Johannes' patch actually always worked for me, but I just had a
> transient problem that made me think it didn't. I think I only booted
> it once, and went "oh, ok, no network, that didn't work".
Thanks for testing.
Upon reflection, it really should check the other WIRELESS_MODE_AC_x bits.
Johannes' patch was indeed correct.
With my AP setup changed, I get about 100 Mb/s RX using netperf. TX is still bad.
@Johannes: OK if I make you the author of the final version of the patch?
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-29 19:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 5:34 WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211] Linus Torvalds
[not found] ` <CA+55aFxe22iWok6UojY=hCoG2k1wNpJ9CfQ0b+STSxq67tb86Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-28 12:13 ` Johannes Berg
[not found] ` <1453983185.2217.12.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-01-28 19:01 ` Linus Torvalds
2016-01-28 20:40 ` Johannes Berg
[not found] ` <1454013625.2332.9.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-01-28 21:44 ` Linus Torvalds
2016-01-28 22:04 ` Linus Torvalds
[not found] ` <CA+55aFzF0gWfvmE+6ZcHmjnO4xp-oVAQ5SWxYJhOzns2ocgCsw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-28 22:12 ` Johannes Berg
2016-01-28 23:01 ` Linus Torvalds
2016-01-29 1:54 ` Larry Finger
[not found] ` <56AAC66C.1080800-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2016-01-29 4:19 ` Linus Torvalds
2016-01-29 8:33 ` Johannes Berg
[not found] ` <CAP71bdVZzUUNwP3py_m1pwU21qMKth=0BmMfLuUb7=B-1840zg@mail.gmail.com>
[not found] ` <CAP71bdVZzUUNwP3py_m1pwU21qMKth=0BmMfLuUb7=B-1840zg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-29 16:15 ` Johannes Berg
2016-01-29 16:54 ` Larry Finger
[not found] ` <1454084146.2800.0.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-01-29 17:54 ` Larry Finger
[not found] ` <56ABA73C.1060504-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2016-01-29 18:39 ` Linus Torvalds
[not found] ` <CA+55aFysqqp-BCZs1ue6_1tE=h9SOUZTH_o7TwGbsaBnaFvXGA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-29 19:42 ` Larry Finger [this message]
[not found] ` <56ABC0BC.9010202-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2016-01-29 20:04 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56ABC0BC.9010202@lwfinger.net \
--to=larry.finger-tq5ms3gmjblk1umjsbkqmq@public$(echo .)gmane.org \
--cc=chaoming_li-kXabqFNEczNtrwSWzY7KCg@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public$(echo .)gmane.org \
--cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox