From: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
To: Jay Vosburgh <jay.vosburgh@canonical•com>
Cc: "Bjørnar Ness" <bjornar.ness@gmail•com>,
netdev <netdev@vger•kernel.org>,
"Veaceslav Falico" <vfalico@gmail•com>,
"Andy Gospodarek" <gospo@cumulusnetworks•com>,
"Jiri Pirko" <jiri@resnulli•us>,
"Michael S. Tsirkin" <mst@redhat•com>,
virtualization@lists•linux-foundation.org
Subject: Re: bonding (IEEE 802.3ad) not working with qemu/virtio
Date: Fri, 29 Jan 2016 22:48:26 +0100 [thread overview]
Message-ID: <56ABDE2A.7010301@cumulusnetworks.com> (raw)
In-Reply-To: <28285.1454103900@famine>
On 01/29/2016 10:45 PM, Jay Vosburgh wrote:
> Nikolay Aleksandrov <nikolay@cumulusnetworks•com> wrote:
>
>> On 01/25/2016 05:24 PM, Bjørnar Ness wrote:
>>> As subject says, 802.3ad bonding is not working with virtio network model.
>>>
>>> The only errors I see is:
>>>
>>> No 802.3ad response from the link partner for any adapters in the bond.
>>>
>>> Dumping the network traffic shows that no LACP packets are sent from the
>>> host running with virtio driver, changing to for example e1000 solves
>>> this problem
>>> with no configuration changes.
>>>
>>> Is this a known problem?
>>>
>> [Including bonding maintainers for comments]
>>
>> Hi,
>> Here's a workaround patch for virtio_net devices that "cheats" the
>> duplex test (which is the actual problem). I've tested this locally
>> and it works for me.
>> I'd let the others comment on the implementation, there're other signs
>> that can be used to distinguish a virtio_net device so I'm open to suggestions.
>> Also feedback if this is at all acceptable would be appreciated.
>
> Should virtio instead provide an arbitrary speed and full duplex
> to ethtool, as veth does?
>
> Creating a magic whitelist of devices deep inside the 802.3ad
> implementation seems less desirable.
>
TBH, I absolutely agree. In fact here's what we've been doing:
add set_settings which allows the user to set any speed/duplex
and get_settings of course to retrieve that. This is also useful
for testing other stuff that requires speed and duplex, not only
for the bonding case.
I'll add the virtio_net maintainers to the discussion, see if it's
okay with everyone and I'll move to send patches once net-next opens up.
Thanks!
> -J
>
> ---
> -Jay Vosburgh, jay.vosburgh@canonical•com
>
next prev parent reply other threads:[~2016-01-29 21:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 16:24 bonding (IEEE 802.3ad) not working with qemu/virtio Bjørnar Ness
2016-01-28 13:33 ` Jiri Pirko
2016-01-28 13:53 ` Nikolay Aleksandrov
2016-01-28 14:10 ` Nikolay Aleksandrov
2016-01-29 21:31 ` Nikolay Aleksandrov
2016-01-29 21:45 ` Jay Vosburgh
2016-01-29 21:48 ` Nikolay Aleksandrov [this message]
2016-01-30 6:59 ` David Miller
2016-01-30 11:34 ` Jiri Pirko
2016-01-30 11:41 ` Nikolay Aleksandrov
2016-01-31 14:50 ` Michael S. Tsirkin
2016-02-01 18:49 ` Rick Jones
2016-01-31 14:58 ` Michael S. Tsirkin
2016-01-31 14:35 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56ABDE2A.7010301@cumulusnetworks.com \
--to=nikolay@cumulusnetworks$(echo .)com \
--cc=bjornar.ness@gmail$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=jay.vosburgh@canonical$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vfalico@gmail$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox