From: David Ahern <dsa@cumulusnetworks•com>
To: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux•com>,
"David S. Miller" <davem@davemloft•net>
Cc: Hannes Frederic Sowa <hannes@stressinduktion•org>,
Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org, David Ahern <dsa@cumulusnetworks•com>,
Hajime Tazaki <thehajime@gmail•com>,
lucien.xin@gmail•com,
Marcelo Ricardo Leitner <marcelo.leitner@gmail•com>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
Subject: Re: [PATCH net v2 2/2] ipv6/udp: use sticky pktinfo egress ifindex on connect()
Date: Mon, 1 Feb 2016 19:06:15 -0700 [thread overview]
Message-ID: <56B00F17.7050007@cumulusnetworks.com> (raw)
In-Reply-To: <56AEC187.1060308@miraclelinux.com>
On 1/31/16 7:23 PM, YOSHIFUJI Hideaki wrote:
>
>
> Hannes Frederic Sowa wrote:
>> On 29.01.2016 12:30, Paolo Abeni wrote:
>>> Currently, the egress interface index specified via IPV6_PKTINFO
>>> is ignored by __ip6_datagram_connect(), so that RFC 3542 section 6.7
>>> can be subverted when the user space application calls connect()
>>> before sendmsg().
>>> Fix it by initializing properly flowi6_oif in connect() before
>>> performing the route lookup.
>>>
>>> Signed-off-by: Paolo Abeni <pabeni@redhat•com>
>>
>> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion•org>
>>
>>
>
> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
>
Dave:
Can you queue these up for 4.4 stable? Fixes 'ping6 -I <interface>' for
VRFs and 4.4 is the first release with VRF for IPv6.
Thanks,
David
next prev parent reply other threads:[~2016-02-02 2:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 11:30 [PATCH net v2 0/2] pv6: fix sticky pktinfo behaviour Paolo Abeni
2016-01-29 11:30 ` [PATCH net v2 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail() Paolo Abeni
2016-01-29 12:33 ` Hannes Frederic Sowa
2016-02-01 2:24 ` YOSHIFUJI Hideaki
2016-01-29 16:00 ` David Ahern
2016-01-29 11:30 ` [PATCH net v2 2/2] ipv6/udp: use sticky pktinfo egress ifindex on connect() Paolo Abeni
2016-01-29 12:33 ` Hannes Frederic Sowa
2016-02-01 2:23 ` YOSHIFUJI Hideaki
2016-02-02 2:06 ` David Ahern [this message]
2016-02-02 2:18 ` David Miller
2016-01-29 12:36 ` [PATCH net v2 0/2] pv6: fix sticky pktinfo behaviour Hannes Frederic Sowa
2016-01-30 4:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B00F17.7050007@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hannes@stressinduktion$(echo .)org \
--cc=hideaki.yoshifuji@miraclelinux$(echo .)com \
--cc=lucien.xin@gmail$(echo .)com \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=thehajime@gmail$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox