From: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
To: Nikolay Aleksandrov <razor@blackwall•org>, netdev@vger•kernel.org
Cc: Roopa Prabhu <roopa@cumulusnetworks•com>,
virtualization@lists•linux-foundation.org, davem@davemloft•net,
"Michael S. Tsirkin" <mst@redhat•com>
Subject: Re: [PATCH net-next] virtio_net: add ethtool support for set and get of settings
Date: Tue, 2 Feb 2016 13:56:16 +0100 [thread overview]
Message-ID: <56B0A770.2030103@cumulusnetworks.com> (raw)
In-Reply-To: <1454417480-28672-1-git-send-email-razor@blackwall.org>
On 02/02/2016 01:51 PM, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
>
> This patch allows the user to set and retrieve speed and duplex of the
> virtio_net device via ethtool. Having this functionality is very helpful
> for simulating different environments and also enables the virtio_net
> device to participate in operations where proper speed and duplex are
> required (e.g. currently bonding lacp mode requires full duplex). Custom
> speed and duplex are not allowed, the user-supplied settings are validated
> before applying. Only full and unknown duplex are allowed to be set.
>
> Example:
> $ ethtool eth1
> Settings for eth1:
> ...
> Speed: Unknown!
> Duplex: Unknown! (255)
> $ ethtool -s eth1 speed 1000 duplex full
> $ ethtool eth1
> Settings for eth1:
> ...
> Speed: 1000Mb/s
> Duplex: Full
>
> Based on a patch by Roopa Prabhu.
>
> CC: Roopa Prabhu <roopa@cumulusnetworks•com>
> CC: Michael S. Tsirkin <mst@redhat•com>
> CC: virtualization@lists•linux-foundation.org
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
> ---
> Allowed to set unknown speed/duplex if the user wants to reset them, though
> the user-space ethtool tool currently doesn't allow setting them.
>
Since the speed can be anything maybe we should allow custom speeds after all ?
I wasn't sure about that so I added the validation.
Thanks,
Nik
next prev parent reply other threads:[~2016-02-02 12:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 12:51 [PATCH net-next] virtio_net: add ethtool support for set and get of settings Nikolay Aleksandrov
2016-02-02 12:56 ` Nikolay Aleksandrov [this message]
2016-02-02 13:23 ` Michael S. Tsirkin
2016-02-02 13:52 ` Nikolay Aleksandrov
2016-02-02 14:10 ` Michael S. Tsirkin
2016-02-03 23:53 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B0A770.2030103@cumulusnetworks.com \
--to=nikolay@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=razor@blackwall$(echo .)org \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox