From: roopa <roopa@cumulusnetworks•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: netdev@vger•kernel.org, davem@davemloft•net, idosch@mellanox•com,
eladr@mellanox•com, yotamg@mellanox•com, ogerlitz@mellanox•com,
yishaih@mellanox•com, dledford@redhat•com, sean.hefty@intel•com,
hal.rosenstock@gmail•com, eugenia@mellanox•com,
nikolay@cumulusnetworks•com, hadarh@mellanox•com,
jhs@mojatatu•com, john.fastabend@gmail•com,
jeffrey.t.kirsher@intel•com, jbenc@redhat•com
Subject: Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it
Date: Sun, 07 Feb 2016 12:18:35 -0800 [thread overview]
Message-ID: <56B7A69B.5040101@cumulusnetworks.com> (raw)
In-Reply-To: <1454496482-13961-1-git-send-email-jiri@resnulli.us>
On 2/3/16, 2:47 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox•com>
>
> There a is need for some userspace API that would allow to expose things
> that are not directly related to any device class like net_device of
> ib_device, but rather chip-wide/switch-ASIC-wide stuff.
>
> Use cases:
> 1) get/set of port type (Ethernet/InfiniBand)
> 2) monitoring of hardware messages to and from chip
> 3) setting up port splitters - split port into multiple ones and squash again,
> enables usage of splitter cable
> 4) setting up shared buffers - shared among multiple ports within one chip
>
> First patch of this set introduces a new generic Netlink based interface,
> called "devlink". It is similar to nl80211 model and it is heavily
> influenced by it, including the API definition. The devlink introduction patch
> implements use cases 1) and 2). Other 2 are in development atm and will
> be addressed by follow-ups.
>
> It is very convenient for drivers to use devlink, as you can see in other
> patches in this set.
>
> Counterpart for devlink is userspace tool called "dl". Command line interface
> and outputs are derived from "ip" tool so it should be easy for users to get
> used to it.
>
> It is available here:
> https://github.com/jpirko/devlink
Jiri, thanks for this series!. Something like this is definitely needed for chip specific data. But i thought we were going to limit it to chip specific global attributes that cannot be set on a port.
>
> Example usage:
> butter:~$ dl help
> Usage: dl [ OPTIONS ] OBJECT { COMMAND | help }
> where OBJECT := { dev | port | monitor }
> OPTIONS := { -v/--verbose }
>
> butter:~$ dl dev show
> 0: devlink0: bus pci dev 0000:01:00.0
>
> butter:~$ dl port help
> Usage: dl port show [DEV/PORT_INDEX]
> Usage: dl port set DEV/PORT_INDEX [ type { eth | ib | auto} ]
I don't think we should include port specific attributes in this api. ports are netdevs and they should still continue to use 'ip link set'.
So, why not just introduce a rtnetlink ops abstraction for switch ports ?. Example:
static struct rtnl_link_ops swport_link_ops __read_mostly = {
.kind = 'swport',
.setup = swport_setup,
.validate = swport_validate,
};
IFLA_INFO_KIND = swport
IFLA_INFO_DATA = {
IFLA_SWPORT_KIND = 'mlx'
IFLA_SWPORT_TYPE, /* u16 */
IFLA_SWPORT_DESIRED_TYPE, /* u16 */
... more ...
}
IFLA_INFO_DATA can be redirected to the specific switch driver at the switchdev ops/api layer.
ip link set dev swp1 swport_type eth swport_desired_type <blah>
Taking this one step further, the port splitter management can be done in user-space:
And, users/switch port management infra can use 'ip link add type swport ...' to create required switch ports.
Thanks,
Roopa
next prev parent reply other threads:[~2016-02-07 20:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 10:47 [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it Jiri Pirko
2016-02-03 10:47 ` [patch net-next RFC 1/6] Introduce devlink infrastructure Jiri Pirko
2016-02-11 14:31 ` Ivan Vecera
2016-02-11 16:54 ` Jiri Pirko
2016-02-03 10:47 ` [patch net-next RFC 2/6] mlxsw: Implement devlink interface Jiri Pirko
2016-02-03 10:47 ` [patch net-next RFC 3/6] mlxsw: Implement hardware messages notification using devlink Jiri Pirko
2016-02-03 10:48 ` [patch net-next RFC 4/6] mlx4: Implement devlink interface Jiri Pirko
2016-02-16 16:43 ` Or Gerlitz
2016-02-16 16:51 ` Jiri Pirko
2016-02-03 10:48 ` [patch net-next RFC 5/6] mlx4: Implement hardware messages notification using devlink Jiri Pirko
2016-02-03 10:48 ` [patch net-next RFC 6/6] mlx4: Implement port type setting via devlink interface Jiri Pirko
2016-02-03 13:31 ` [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it Jesper Dangaard Brouer
2016-02-03 13:33 ` Jiri Pirko
2016-02-03 15:17 ` Daniel Borkmann
2016-02-04 13:22 ` Hannes Frederic Sowa
2016-02-04 13:26 ` Jiri Pirko
2016-02-05 10:01 ` Hannes Frederic Sowa
2016-02-05 17:38 ` Alexei Starovoitov
2016-02-06 19:40 ` Jiri Pirko
2016-02-08 10:15 ` Hannes Frederic Sowa
2016-02-08 10:55 ` Jiri Pirko
2016-02-08 12:11 ` Hannes Frederic Sowa
2016-02-04 19:01 ` Rosen, Rami
2016-02-05 14:29 ` Jesper Dangaard Brouer
2016-02-07 20:18 ` roopa [this message]
2016-02-08 19:00 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B7A69B.5040101@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dledford@redhat$(echo .)com \
--cc=eladr@mellanox$(echo .)com \
--cc=eugenia@mellanox$(echo .)com \
--cc=hadarh@mellanox$(echo .)com \
--cc=hal.rosenstock@gmail$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jbenc@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=sean.hefty@intel$(echo .)com \
--cc=yishaih@mellanox$(echo .)com \
--cc=yotamg@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox