Subject: Re: [PATCH iproute2 01/21] iplink: bridge: export bridge_id and designated_root

From: Nikolay Aleksandrov <[email-masked]>
Date: Mon, 8 Feb 2016 23:25:51 +0100

On 02/08/2016 11:21 PM, Stephen Hemminger wrote:
> On Mon,  8 Feb 2016 12:55:07 +0100
> Nikolay Aleksandrov <[email-masked]> wrote:
> 
>>  
>> +static void br_dump_bridge_id(const struct ifla_bridge_id *id, char *buf,
>> +			      size_t len)
>> +{
>> +	const unsigned char *x = (const unsigned char *)id;
>> +
>> +	snprintf(buf, len, "%.2x%.2x.%.2x%.2x%.2x%.2x%.2x%.2x", x[0], x[1],
>> +		 x[2], x[3], x[4], x[5], x[6], x[7]);
>> +}
> 
> Please don't reinvent ether_ntoa_r
> 
This was taken from bridge-utils, it actually includes 2 more bytes, it's
not only an ethernet address.