From: Ivan Vecera <ivecera@redhat•com>
To: Sathya Perla <sathya.perla@broadcom•com>
Cc: netdev@vger•kernel.org,
Ajit Khaparde <ajit.khaparde@broadcom•com>,
Padmanabh Ratnakar <padmanabh.ratnakar@broadcom•com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom•com>,
Somnath Kotur <somnath.kotur@broadcom•com>
Subject: Re: [PATCH net-next] be2net: don't report EVB for older chipsets when SR-IOV is disabled
Date: Thu, 11 Feb 2016 12:38:15 +0100 [thread overview]
Message-ID: <56BC72A7.3040100@redhat.com> (raw)
In-Reply-To: <CAKvpyk1u=59YZLoX9kTpTFm0=bXdyE-LaZpCobZwmWo+wa5RTg@mail.gmail.com>
On 11.2.2016 10:56, Sathya Perla wrote:
> On Wed, Feb 10, 2016 at 1:13 PM, Ivan Vecera <ivecera@redhat•com> wrote:
>>
>> The EVB (virtual bridge) functionality should be disabled on older BE3
>> and Lancer chips if SR-IOV is disabled in the NIC's BIOS. This setting
>> is identified by the zero value of total VFs reported by the card.
>> The GET_HSW_CONFIG command cannot be used as it is not supported > by these older chipset's FW.
>>
> ..
>> ---
>> drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
>> index 9c1fc9d..886fe95 100644
>> --- a/drivers/net/ethernet/emulex/benet/be_main.c
>> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
>> @@ -4588,6 +4588,8 @@ static int be_ndo_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq,
>>
>> /* BE and Lancer chips support VEB mode only */
>> if (BEx_chip(adapter) || lancer_chip(adapter)) {
>> + if (!pci_sriov_get_totalvfs(adapter->pdev))
>> + return 0;
>
> Ivan, could you add a one line comment above this check that says "On
> BE3/Lancer the VEB is disabled in non-SRIOV profiles". This is to
> differentiate this behavior from Skyhawk, where the VEB may be enabled
> even in non-SRIOV profiles, like nPAR...
>
> thanks,
> -Sathya
>
Sure Sathya, will send v2.
Ivan
prev parent reply other threads:[~2016-02-11 11:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 12:13 [PATCH net-next] be2net: don't report EVB for older chipsets when SR-IOV is disabled Ivan Vecera
2016-02-11 9:56 ` Sathya Perla
2016-02-11 11:38 ` Ivan Vecera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BC72A7.3040100@redhat.com \
--to=ivecera@redhat$(echo .)com \
--cc=ajit.khaparde@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=padmanabh.ratnakar@broadcom$(echo .)com \
--cc=sathya.perla@broadcom$(echo .)com \
--cc=somnath.kotur@broadcom$(echo .)com \
--cc=sriharsha.basavapatna@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox