From: Or Gerlitz <ogerlitz@mellanox•com>
To: Rick Jones <rick.jones2@hpe•com>,
"David S. Miller" <davem@davemloft•net>
Cc: <netdev@vger•kernel.org>, Eran Ben Elisha <eranbe@mellanox•com>,
"Yishai Hadas" <yishaih@mellanox•com>, Amir Vadai <amir@vadai•me>,
Eugenia Emantayev <eugenia@mellanox•com>
Subject: Re: [PATCH net 1/6] net/mlx4_en: Do not count dropped packets twice
Date: Wed, 17 Feb 2016 12:19:48 +0200 [thread overview]
Message-ID: <56C44944.20803@mellanox.com> (raw)
In-Reply-To: <56C36B1D.3050007@hpe.com>
On 2/16/2016 8:31 PM, Rick Jones wrote:
>
> I'm still not clear on when an Acked-by is appropriate, but given that
> this has been a non-trivial frustration for a long time, a hearty
> endorsement from me. Perhaps not important enough but it would be
> nice to have it flow back a release or two.
sure, will ask stable inclusion as well
>
> That said, should mlx4_en_stats->RdropOvflw still be going into both
> rx_fifo_errors and rx_over_errors?
>
> stats->rx_over_errors = be32_to_cpu(mlx4_en_stats->RdropOvflw);
> stats->rx_crc_errors = be32_to_cpu(mlx4_en_stats->RCRC);
> stats->rx_frame_errors = 0;
> stats->rx_fifo_errors = be32_to_cpu(mlx4_en_stats->RdropOvflw);
yep, point taken, we will leave it only for the over ones, thanks for
pointing this out
Or.
next prev parent reply other threads:[~2016-02-17 10:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 15:01 [PATCH net 0/6] Mellanox 10/40G mlx4 driver fixes for 4.5-rc Or Gerlitz
2016-02-16 15:01 ` [PATCH net 1/6] net/mlx4_en: Do not count dropped packets twice Or Gerlitz
2016-02-16 18:31 ` Rick Jones
2016-02-17 10:19 ` Or Gerlitz [this message]
2016-02-16 15:01 ` [PATCH net 2/6] net/mlx4_en: Choose time-stamping shift value according to HW frequency Or Gerlitz
2016-02-16 15:01 ` [PATCH net 3/6] net/mlx4_core: Fix potential corruption in counters database Or Gerlitz
2016-02-16 15:01 ` [PATCH net 4/6] net/mlx4_core: Do not BUG_ON during reset when PCI is offline Or Gerlitz
2016-02-16 18:30 ` Sergei Shtylyov
2016-02-17 9:21 ` Or Gerlitz
2016-02-17 10:53 ` Sergei Shtylyov
2016-02-16 21:21 ` Sergei Shtylyov
2016-02-17 18:50 ` Sergei Shtylyov
2016-02-16 15:01 ` [PATCH net 5/6] net/mlx4_core: Set UAR page size to 4KB regardless of system page size Or Gerlitz
2016-02-16 15:01 ` [PATCH net 6/6] net/mlx4_en: Avoid changing dev->features directly in run-time Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C44944.20803@mellanox.com \
--to=ogerlitz@mellanox$(echo .)com \
--cc=amir@vadai$(echo .)me \
--cc=davem@davemloft$(echo .)net \
--cc=eranbe@mellanox$(echo .)com \
--cc=eugenia@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rick.jones2@hpe$(echo .)com \
--cc=yishaih@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox