public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Daniel Borkmann <daniel@iogearbox•net>,
	Cong Wang <xiyou.wangcong@gmail•com>
Cc: David Miller <davem@davemloft•net>,
	Linux Kernel Network Developers <netdev@vger•kernel.org>
Subject: Re: [net-next PATCH v2 1/1] net_sched fix: reclassification needs to consider ether protocol changes
Date: Thu, 18 Feb 2016 07:26:13 -0500	[thread overview]
Message-ID: <56C5B865.5050608@mojatatu.com> (raw)
In-Reply-To: <56C5B0AB.8040802@iogearbox.net>

On 16-02-18 06:53 AM, Daniel Borkmann wrote:
> On 02/17/2016 06:27 PM, Cong Wang wrote:

>>>          const struct tcf_proto *old_tp = tp;
>>>          int limit = 0;
>>> -
>>
>> Why remove this empty line? I think it is still useful. :)
>>
>> Also your patch should be targeted to -net instead of -net-next, since it
>> fixes a bug.
>
> Yeah, good point. That should go to -net (minus the unrelated white
> space change).
>


One patch coming right up boys;->

cheers,
jamal

  reply	other threads:[~2016-02-18 12:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 11:37 [net-next PATCH v2 0/1] tc reclassification needs to consider ether protocol changes Jamal Hadi Salim
2016-02-17 11:37 ` [net-next PATCH v2 1/1] net_sched fix: " Jamal Hadi Salim
2016-02-17 17:27   ` Cong Wang
2016-02-18 11:53     ` Daniel Borkmann
2016-02-18 12:26       ` Jamal Hadi Salim [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-02-16 12:37 Jamal Hadi Salim
2016-02-16 15:20 ` Daniel Borkmann
2016-02-17 11:19   ` Jamal Hadi Salim
2016-02-17 11:48     ` Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C5B865.5050608@mojatatu.com \
    --to=jhs@mojatatu$(echo .)com \
    --cc=daniel@iogearbox$(echo .)net \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=xiyou.wangcong@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox