From: Robert Shearman <rshearma@brocade•com>
To: roopa <roopa@cumulusnetworks•com>, David Miller <davem@davemloft•net>
Cc: <netdev@vger•kernel.org>, <ebiederm@xmission•com>
Subject: Re: [PATCH net-next 1/2] mpls: packet stats
Date: Fri, 19 Feb 2016 09:57:47 +0000 [thread overview]
Message-ID: <56C6E71B.3080509@brocade.com> (raw)
In-Reply-To: <56C385E0.2000405@cumulusnetworks.com>
On 16/02/16 20:26, roopa wrote:
> On 2/16/16, 7:41 AM, David Miller wrote:
>> Statistics not provided via netlink are useless in real installations.
>>
>> In fact I would say to forego the proc interface entirely, it's a second
>> class citizen for statistics gathering and has a non-triviel per-device
>> cost for instantiation.
>>
> +1
>
> I agree with the cost too.
>
> Robert, I was thinking of responding to your series to add netlink stats for AF_MPLS in
> rtnl_af_ops (similar to IFLA_INET6_STATS). But, soon realized that it is currently used by ipv6 alone
> and it also ended up with a skip filter (RTEXT_FILTER_SKIP_STATS). So, extending that interface for
> mpls is not the right thing to do either.
ipv4 doesn't have per-interface stats, so the fact that it doesn't use
fill_link_af to export stats doesn't really add much to the argument.
The real issue with the IFLA_INET6_STATS mechanism is that they are
included in netlink broadcasts, not just netlink unicasts and there is
no way of filtering for broadcasts at the moment.
> There is work being done for a separate netlink infrastructure for stats.
> I would wait for that infrastructure to be ready to add mpls stats. It should be available soon.
Great, any details on what it would look like? Can I assist in any way
in the development?
In the mean time, I'll rebase and resubmit the ip ttl propagation patch
separately.
Thanks,
Rob
next prev parent reply other threads:[~2016-02-19 9:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 19:27 [PATCH net-next 0/2] mpls: packet stats and ttl propagation config Robert Shearman
2016-02-05 19:27 ` [PATCH net-next 1/2] mpls: packet stats Robert Shearman
2016-02-06 10:58 ` Francois Romieu
2016-02-08 11:51 ` David Laight
2016-02-16 20:08 ` David Miller
2016-02-08 16:17 ` Robert Shearman
2016-02-16 15:41 ` David Miller
2016-02-16 20:26 ` roopa
2016-02-19 9:57 ` Robert Shearman [this message]
2016-07-29 5:19 ` Roopa Prabhu
2016-02-05 19:27 ` [PATCH net-next 2/2] mpls: allow TTL propagation to/from IP packets to be configured Robert Shearman
2016-02-06 18:36 ` Eric W. Biederman
2016-02-09 16:10 ` Robert Shearman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C6E71B.3080509@brocade.com \
--to=rshearma@brocade$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roopa@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox