From: Xing Zheng <zhengxing-TNX95d0MmH7DzftRWevZcw@public•gmane.org>
To: Michael Niewoehner <linux-zzFNMPX9jIaDjmgdnaGrkw@public•gmane.org>
Cc: caesar.upstream-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org,
heiko-4mtYJXux2i+zQB+pC5nmwQ@public•gmane.org,
zhengxing <zhengxing-TNX95d0MmH7DzftRWevZcw@public•gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org,
Shuyu Wei <sy.w-1ViLX0X+lBJBDgjK7y7TUQ@public•gmane.org>,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org
Subject: Re: [PATCH RESEND] ethernet:arc: Move arc_emac_tx_clean() into arc_emac_tx() and disable tx interrut
Date: Fri, 19 Feb 2016 21:59:27 +0800 [thread overview]
Message-ID: <56C71FBF.1070303@rock-chips.com> (raw)
In-Reply-To: <85B47C95-B524-4A25-90C7-95AE614AB3A2-zzFNMPX9jIaDjmgdnaGrkw@public.gmane.org>
On 2016年02月19日 19:13, Michael Niewoehner wrote:
> Am 19.02.2016 um 07:59 schrieb Shuyu Wei<sy.w@outlook•com>:
>
>> Doing tx_clean() inside poll() may scramble the tx ring buffer if
>> tx() is running. This will cause tx to stop working, which can be
>> reproduced by simultaneously downloading two large files at high speed.
>>
>> Moving tx_clean() into tx() will prevent this. And tx interrupt is no
>> longer needed now.
>>
>> Signed-off-by: Shuyu Wei<sy.w@outlook•com>
> Tested-by: Michael Niewoehner<linux@mniewoehner•de>
Tested-by: Xing Zheng <zhengxing@rock-chips•com>
Thanks.
--
- Xing Zheng
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2016-02-19 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 6:59 [PATCH RESEND] ethernet:arc: Move arc_emac_tx_clean() into arc_emac_tx() and disable tx interrut Shuyu Wei
2016-02-19 11:13 ` Michael Niewoehner
[not found] ` <85B47C95-B524-4A25-90C7-95AE614AB3A2-zzFNMPX9jIaDjmgdnaGrkw@public.gmane.org>
2016-02-19 13:59 ` Xing Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C71FBF.1070303@rock-chips.com \
--to=zhengxing-tnx95d0mmh7dzftrwevzcw@public$(echo .)gmane.org \
--cc=caesar.upstream-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public$(echo .)gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public$(echo .)gmane.org \
--cc=linux-zzFNMPX9jIaDjmgdnaGrkw@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=sy.w-1ViLX0X+lBJBDgjK7y7TUQ@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox