Subject: Re: [net-next][PATCH 11/13] RDS: IB: add Fastreg MR (FRMR) detection support

From: Bart Van Assche <[email-masked]>
Date: Mon, 22 Feb 2016 07:38:38 -0800

On 02/21/16 19:36, David Miller wrote:
> From: Santosh Shilimkar <[email-masked]>
> Date: Sat, 20 Feb 2016 03:30:02 -0800
>
>> @@ -54,6 +55,8 @@ module_param(rds_ib_mr_8k_pool_size, int, 0444);
>>   MODULE_PARM_DESC(rds_ib_mr_8k_pool_size, " Max number of 8K mr per HCA");
>>   module_param(rds_ib_retry_count, int, 0444);
>>   MODULE_PARM_DESC(rds_ib_retry_count, " Number of hw retries before reporting an error");
>> +module_param(prefer_frmr, bool, 0444);
>> +MODULE_PARM_DESC(prefer_frmr, "Preferred MR method if both FMR and FRMR supported");
>
> Sorry, you're going to have to create a real run time method to configure
> this parameter.
>
> I'm strongly against module parameters.
>
> Please don't go into details about why this might be difficult to do,
> I'm totally not interested.  Doing things properly is sometimes not
> easy, that's life.

Hello Santosh,

What is the purpose of the prefer_frmr kernel module parameter ? Is this 
a parameter that is useful to RDS users or is its only purpose to allow 
developers of the RDS module to test both the FMR and FRMR code paths on 
hardware that supports both MR methods ?

Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email-masked]
More majordomo info at  http://vger.kernel.org/majordomo-info.html