From: Daniel Borkmann <daniel@iogearbox•net>
To: Jamal Hadi Salim <jhs@mojatatu•com>, davem@davemloft•net
Cc: netdev@vger•kernel.org, xiyou.wangcong@gmail•com,
alexei.starovoitov@gmail•com
Subject: Re: [net-next PATCH 3/5] Support to encoding decoding skb prio on IFE action
Date: Mon, 22 Feb 2016 18:01:11 +0100 [thread overview]
Message-ID: <56CB3ED7.90202@iogearbox.net> (raw)
In-Reply-To: <1456147304-13355-4-git-send-email-jhs@emojatatu.com>
On 02/22/2016 02:21 PM, Jamal Hadi Salim wrote:
> From: Jamal Hadi Salim <jhs@mojatatu•com>
[...]
> +static int skbprio_check(struct sk_buff *skb, struct tcf_meta_info *e)
> +{
> + return check_meta_u32(skb->priority, e);
> +}
> +
> +static int skbprio_encode(struct sk_buff *skb, void *skbdata,
> + struct tcf_meta_info *e)
> +{
> + u32 ifeprio = skb->priority; /* avoid having to cast skb->priority*/
> +
> + pr_emerg("encode skbprio %d\n", ifeprio);
Ditto ... and this for every packet on encap and decap ...
> + return encode_meta_u32(ifeprio, skbdata, e);
> +}
> +
> +static int skbprio_decode(struct sk_buff *skb, void *data, u16 len)
> +{
> + u32 ifeprio = *(u32 *) data;
> +
> + skb->priority = ntohl(ifeprio);
> + pr_emerg("decode skbprio %d\n", skb->priority);
> + return 0;
> +}
> +
> +static struct tcf_meta_ops ife_prio_ops = {
> + .metaid = IFE_META_PRIO,
> + .metatype = NLA_U32,
> + .name = "skbprio",
> + .synopsis = "skb prio metadata",
> + .check_presence = skbprio_check,
> + .encode = skbprio_encode,
> + .decode = skbprio_decode,
> + .get = get_meta_u32,
> + .alloc = alloc_meta_u32,
> + .owner = THIS_MODULE,
> +};
> +
> +static int __init ifeprio_init_module(void)
> +{
> + pr_info("Loaded IFE skb prio\n");
> + return register_ife_op(&ife_prio_ops);
> +}
> +
> +static void __exit ifeprio_cleanup_module(void)
> +{
> + unregister_ife_op(&ife_prio_ops);
> + pr_info("Unloaded IFE skb prio\n");
> +}
> +
> +module_init(ifeprio_init_module);
> +module_exit(ifeprio_cleanup_module);
> +
> +MODULE_AUTHOR("Jamal Hadi Salim(2015)");
> +MODULE_DESCRIPTION("Inter-FE skb prio metadata action");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS_IFE_META(IFE_META_PRIO);
>
next prev parent reply other threads:[~2016-02-22 17:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 13:21 [net-next PATCH 0/5] net_sched: Add support for IFE action Jamal Hadi Salim
2016-02-22 13:21 ` [net-next PATCH 1/5] introduce " Jamal Hadi Salim
2016-02-22 13:21 ` [net-next PATCH 2/5] Support to encoding decoding skb mark on " Jamal Hadi Salim
2016-02-22 13:21 ` [net-next PATCH 3/5] Support to encoding decoding skb prio " Jamal Hadi Salim
2016-02-22 17:01 ` Daniel Borkmann [this message]
2016-02-22 13:21 ` [net-next PATCH 4/5] Support to encoding decoding skb hashid " Jamal Hadi Salim
2016-02-22 16:56 ` Daniel Borkmann
2016-02-22 13:21 ` [net-next PATCH 5/5] Support to encoding decoding skb queue map " Jamal Hadi Salim
2016-02-22 16:59 ` Daniel Borkmann
2016-02-22 21:03 ` John Fastabend
2016-02-23 12:17 ` Jamal Hadi Salim
2016-02-23 19:33 ` John Fastabend
2016-02-22 16:47 ` [net-next PATCH 0/5] net_sched: Add support for " Daniel Borkmann
2016-02-23 12:09 ` Jamal Hadi Salim
2016-02-23 13:20 ` Daniel Borkmann
2016-02-23 14:28 ` Jamal Hadi Salim
2016-02-23 15:34 ` Daniel Borkmann
2016-02-24 12:49 ` Jamal Hadi Salim
2016-02-24 17:48 ` Daniel Borkmann
2016-02-25 12:23 ` Jamal Hadi Salim
2016-02-25 21:34 ` Daniel Borkmann
2016-02-25 22:40 ` Jamal Hadi Salim
2016-02-26 0:03 ` Daniel Borkmann
2016-02-24 17:58 ` Daniel Borkmann
2016-02-25 12:35 ` Jamal Hadi Salim
2016-02-23 7:00 ` Cong Wang
2016-02-23 12:18 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CB3ED7.90202@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jhs@mojatatu$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox