From: Daniel Borkmann <daniel@iogearbox•net>
To: Jamal Hadi Salim <jhs@mojatatu•com>, davem@davemloft•net
Cc: netdev@vger•kernel.org, xiyou.wangcong@gmail•com,
alexei.starovoitov@gmail•com, john.fastabend@gmail•com,
dj@verizon•com
Subject: Re: [net-next PATCH v2 1/5] introduce IFE action
Date: Tue, 23 Feb 2016 14:32:35 +0100 [thread overview]
Message-ID: <56CC5F73.9080201@iogearbox.net> (raw)
In-Reply-To: <1456231760-2513-2-git-send-email-jhs@emojatatu.com>
On 02/23/2016 01:49 PM, Jamal Hadi Salim wrote:
> From: Jamal Hadi Salim <jhs@mojatatu•com>
>
> This action allows for a sending side to encapsulate arbitrary metadata
> which is decapsulated by the receiving end.
> The sender runs in encoding mode and the receiver in decode mode.
> Both sender and receiver must specify the same ethertype.
> At some point we hope to have a registered ethertype and we'll
> then provide a default so the user doesnt have to specify it.
> For now we enforce the user specify it.
>
> Lets show example usage where we encode icmp from a sender towards
> a receiver with an skbmark of 17; both sender and receiver use
> ethertype of 0xdead to interop.
On a conceptual level, as this is an L2 encap with TLVs, why not having
a normal device driver for this like we have in other cases that would
encode/decode the meta data itself?
[...]
> +/*XXX: We need to encode the total number of bytes consumed */
> +enum {
> + TCA_IFE_UNSPEC,
> + TCA_IFE_PARMS,
> + TCA_IFE_TM,
> + TCA_IFE_DMAC,
> + TCA_IFE_SMAC,
> + TCA_IFE_TYPE,
> + TCA_IFE_METALST,
> + __TCA_IFE_MAX
> +};
> +#define TCA_IFE_MAX (__TCA_IFE_MAX - 1)
> +
> +#define IFE_META_SKBMARK 1
> +#define IFE_META_HASHID 2
> +#define IFE_META_PRIO 3
> +#define IFE_META_QMAP 4
> +/*Can be overriden at runtime by module option*/
> +#define __IFE_META_MAX 5
> +#define IFE_META_MAX (__IFE_META_MAX - 1)
> +
> +#endif
[...]
> +module_init(ife_init_module);
> +module_exit(ife_cleanup_module);
> +
> +module_param(max_metacnt, int, 0);
> +MODULE_AUTHOR("Jamal Hadi Salim(2015)");
> +MODULE_DESCRIPTION("Inter-FE LFB action");
> +MODULE_LICENSE("GPL");
> +MODULE_PARM_DESC(max_metacnt, "Upper bound of metadata id");
Why does IFE_META_MAX need to be configurable as a module parameter?
Shouldn't the core kernel be in charge of the IFE_META_*?
Thanks,
Daniel
next prev parent reply other threads:[~2016-02-23 13:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 12:49 [net-next PATCH v2 0/5] net_sched: Add support for IFE action Jamal Hadi Salim
2016-02-23 12:49 ` [net-next PATCH v2 1/5] introduce " Jamal Hadi Salim
2016-02-23 13:32 ` Daniel Borkmann [this message]
2016-02-23 14:39 ` Jamal Hadi Salim
2016-02-23 16:12 ` Daniel Borkmann
2016-02-23 21:31 ` Cong Wang
2016-02-24 5:46 ` Simon Horman
2016-02-24 12:39 ` Jamal Hadi Salim
2016-02-24 12:52 ` Jamal Hadi Salim
2016-02-23 21:44 ` Cong Wang
2016-02-24 13:09 ` Jamal Hadi Salim
2016-02-24 17:39 ` Cong Wang
2016-02-24 17:37 ` Daniel Borkmann
2016-02-25 12:20 ` Jamal Hadi Salim
2016-02-25 21:46 ` Daniel Borkmann
2016-02-25 22:07 ` John Fastabend
2016-02-25 22:46 ` Jamal Hadi Salim
2016-02-23 12:49 ` [net-next PATCH v2 2/5] Support to encoding decoding skb mark on " Jamal Hadi Salim
2016-02-23 12:49 ` [net-next PATCH v2 3/5] Support to encoding decoding skb prio " Jamal Hadi Salim
2016-02-23 12:49 ` [net-next PATCH v2 4/5] Support to encoding decoding skb hashid " Jamal Hadi Salim
2016-02-23 12:49 ` [net-next PATCH v2 5/5] Support to encoding decoding skb queue map " Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC5F73.9080201@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dj@verizon$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox