From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: Linux Kernel Network Developers <netdev@vger•kernel.org>
Subject: Re: [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions
Date: Thu, 25 Feb 2016 07:17:06 -0500 [thread overview]
Message-ID: <56CEF0C2.4000901@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpWXbEtv6q-Uj9O+-HPDdBkMj27qo0TYXjzGoQm9cGgicQ@mail.gmail.com>
On 16-02-24 12:21 PM, Cong Wang wrote:
> On Wed, Feb 24, 2016 at 5:19 AM, Jamal Hadi Salim <jhs@mojatatu•com> wrote:
[..]
>> Did you mean something else or am i missing the obvious?
>> I am looking at the call sites for tcf_action_destroy():
>> -tc_dump_tfilter() has access to *net
>> -tcf_exts_change() - one level lower it has access to *net; i think you
>> added this to your patch too.
>> -tcf_action_init() has *net.
>
> Well, having net is not enough, we still need net_id to retrieve hinfo,
I thought you could pass a pointer to the net_id from all those call
sites? Anyways, we can worry about that later.
Acked-by: Jamal Hadi Salim <jhs@mojatatu•com>
next prev parent reply other threads:[~2016-02-25 12:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 23:57 [Patch net-next v2 0/2] net_sched: add network namespace support for tc actions Cong Wang
2016-02-22 23:57 ` [Patch net-next v2 1/2] net_sched: prepare tcf_hashinfo_destroy() for netns support Cong Wang
2016-02-23 13:01 ` Jamal Hadi Salim
2016-02-22 23:57 ` [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions Cong Wang
2016-02-23 13:14 ` Jamal Hadi Salim
2016-02-23 22:23 ` Cong Wang
2016-02-24 13:19 ` Jamal Hadi Salim
2016-02-24 17:21 ` Cong Wang
2016-02-25 12:17 ` Jamal Hadi Salim [this message]
2016-02-24 18:37 ` Cong Wang
2016-02-25 19:16 ` [Patch net-next v2 0/2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CEF0C2.4000901@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox