From: Brian Russell <brian.russell@brocade•com>
To: Jiri Benc <jbenc@redhat•com>
Cc: <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next v2 2/2] vxlan: support GPE/NSH
Date: Tue, 1 Mar 2016 11:10:40 +0000 [thread overview]
Message-ID: <56D578B0.9020605@brocade.com> (raw)
In-Reply-To: <20160215174917.025b066c@griffin>
On 15/02/16 16:49, Jiri Benc wrote:
> On Thu, 11 Feb 2016 19:57:06 +0000, Brian Russell wrote:
>> +skip_l2:
>> skb_reset_network_header(skb);
>> +
>> /* In flow-based mode, GBP is carried in dst_metadata */
>> - if (!(vs->flags & VXLAN_F_COLLECT_METADATA))
>> + if (!(vs->flags & VXLAN_F_COLLECT_METADATA) &&
>> + !(vs->flags & VXLAN_F_GPE))
>> skb->mark = md->gbp;
>
> This is completely wrong. You cannot return a packet with a garbage in
> place of the Ethernet header from ARPHRD_ETHER interface. For proper
> VXLAN-GPE support, the vxlan interface needs to be in L3 mode, e.g.
> ARPHRD_NONE.
>
Yes, I see that, thanks for the clarification. (I was "getting away with" the broken code in my test as I was diverting packets bound for another interface onto the vxlan via a netfilter target.)
> To support L3 mode, the vxlan driver needs *tons* of cleanups (or tons
> of duplicate code). This is exactly what I've done and what I'm in
> process of merging. The number of patches is too big to be submitted as
> a single patchset, hence I'm submitting in parts. The first one has
> been already merged (net-next commit 19f76f63507f). For the full code,
> look at: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_jbenc_linux-2Dvxlan_commits_master&d=CwICAg&c=IL_XqQWOjubgfqINi2jTzg&r=Doie302MT-sezztwQymkPQ3_4X5Q3a0mKbiZzzoNm-0&m=dDreCW0fBOYAR9o10-A-Ifd5jVGfykbZGpkzbN11nMc&s=qdPcZavap7kJQOuN2Udz-h-CDNkP4GiV_CYrQwXD_Kg&e=
>
> Comments are welcome.
>
This looks great so I'll drop my vxlan-gpe patch. I'd like to add the NSH capability on top of your patchset which I see is currently under review. Or did you have plans to roll out NSH soon also?
Thanks,
Brian
> Jiri
>
next prev parent reply other threads:[~2016-03-01 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 19:57 [PATCH net-next v2 0/2] NSH and VxLAN-GPE Brian Russell
2016-02-11 19:57 ` [PATCH net-next v2 1/2] nsh: encapsulation module Brian Russell
2016-02-15 17:01 ` Jiri Benc
2016-03-01 11:11 ` Brian Russell
2016-02-17 3:31 ` Alexei Starovoitov
2016-03-01 11:11 ` Brian Russell
2016-02-11 19:57 ` [PATCH net-next v2 2/2] vxlan: support GPE/NSH Brian Russell
2016-02-15 16:49 ` Jiri Benc
2016-03-01 11:10 ` Brian Russell [this message]
2016-03-01 18:20 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D578B0.9020605@brocade.com \
--to=brian.russell@brocade$(echo .)com \
--cc=jbenc@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox