From: David Ahern <dsa@cumulusnetworks•com>
To: Andy Gospodarek <gospo@cumulusnetworks•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next] ipv4: properly apply change to ignore_routes_on_linkdown to all interfaces
Date: Wed, 2 Mar 2016 10:36:18 -0800 [thread overview]
Message-ID: <56D732A2.5080607@cumulusnetworks.com> (raw)
In-Reply-To: <20160302182827.GZ33942@gospo.home.greyhouse.net>
On 3/2/16 10:28 AM, Andy Gospodarek wrote:
>> This seems wrong -- changing the 'all' and 'default' settings for a sysctl
>> >should not require walking the interface list.
> Not if you want to actually apply the config to all the interfaces. If
> you notice this borrows heavily from the sysctl to control ipv4
> forwarding as it behaves in a manner that I would consider to be
> proper.
>
When the config is checked runtime it can look at 'all' and the setting
for the individual interface; you don't have to walk the devices and
apply the setting each time it is changed. See the keep_addr_on_down
implementation.
next prev parent reply other threads:[~2016-03-02 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 16:43 [PATCH net-next] ipv4: properly apply change to ignore_routes_on_linkdown to all interfaces Andy Gospodarek
2016-03-02 18:17 ` David Ahern
2016-03-02 18:28 ` Andy Gospodarek
2016-03-02 18:36 ` David Ahern [this message]
2016-03-02 18:46 ` Andy Gospodarek
2016-03-07 3:38 ` David Miller
2016-03-07 13:21 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D732A2.5080607@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox