From: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: netdev@vger•kernel.org, roopa@cumulusnetworks•com
Subject: Re: [PATCH iproute2 net-next] bridge: mdb: add support for extended router port information
Date: Sun, 6 Mar 2016 22:12:56 +0100 [thread overview]
Message-ID: <56DC9D58.6000508@cumulusnetworks.com> (raw)
In-Reply-To: <20160306125604.7978a1d9@xeon-e3>
On 03/06/2016 09:56 PM, Stephen Hemminger wrote:
> On Thu, 3 Mar 2016 16:19:34 +0100
> Nikolay Aleksandrov <nikolay@cumulusnetworks•com> wrote:
>
>> +static int is_temp_mcast_rtr(__u8 type)
>> {
>> + if (type == MDB_RTR_TYPE_TEMP_QUERY || type == MDB_RTR_TYPE_TEMP)
>> + return 1;
>> + else
>> + return 0;
>> +}
>> +
>
> Minor style issues, why not much simpler:
>
> static bool is_tmp_mcast_rtr(__u8 type)
> {
> return (type == MDB_RTR_TYPE_TEMP_QUERY || type == MDB_RTR_TYPE_TEMP);
> }
>
Yeah, I considered it but I don't know why I went with
the more explicit one. I'll make a v3 with the change. :-)
Thanks,
Nik
prev parent reply other threads:[~2016-03-06 21:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 15:19 [PATCH iproute2 net-next] bridge: mdb: add support for extended router port information Nikolay Aleksandrov
2016-03-03 16:20 ` [PATCH iproute2 net-next v2] " Nikolay Aleksandrov
2016-03-07 9:32 ` [PATCH iproute2 net-next v3] " Nikolay Aleksandrov
2016-03-07 10:10 ` [PATCH iproute2 net-next v4] " Nikolay Aleksandrov
2016-03-14 6:37 ` Stephen Hemminger
2016-03-14 10:04 ` [PATCH iproute2 net-next v5] " Nikolay Aleksandrov
2016-03-06 20:56 ` [PATCH iproute2 net-next] " Stephen Hemminger
2016-03-06 21:12 ` Nikolay Aleksandrov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DC9D58.6000508@cumulusnetworks.com \
--to=nikolay@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox