From: Felix Fietkau <nbd-p3rKhJxN3npAfugRpC6u6w@public•gmane.org>
To: Avery Pennarun <apenwarr-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
Michal Kazior
<michal.kazior-++hxYGjEMp0AvxtiuMwx3w@public•gmane.org>
Cc: Tim Shepard <shep-FrUbXkNCsVf2fBVCVOL8/A@public•gmane.org>,
linux-wireless
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public•gmane.org>,
Network Development
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
Eric Dumazet
<eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
Dave Taht <dave.taht-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
Emmanuel Grumbach
<emmanuel.grumbach-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>,
Andrew Mcgregor
<andrewmcgr-hpIqsD4AKlfQT0dZR+AlfA@public•gmane.org>
Subject: Re: [RFC/RFT] mac80211: implement fq_codel for software queuing
Date: Mon, 7 Mar 2016 16:09:30 +0100 [thread overview]
Message-ID: <56DD99AA.8050403@openwrt.org> (raw)
In-Reply-To: <CAPp0ZBYP9UzUTtPz=vivUQkE2FiGSsJjDaecQtPuK8y_d3ccqA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 2016-03-07 15:05, Avery Pennarun wrote:
> On Fri, Mar 4, 2016 at 1:32 AM, Michal Kazior <michal.kazior-++hxYGjEMp0AvxtiuMwx3w@public•gmane.org> wrote:
>> On 4 March 2016 at 03:48, Tim Shepard <shep-FrUbXkNCsVf2fBVCVOL8/A@public•gmane.org> wrote:
>> [...]
>>> (I am interested in knowing what other mac80211 drivers have been
>>> modified to use the mac80211 intermediate software queues. I know
>>> Michal mentioned he has patches for ath10k that are not yet released,
>>> and I know Felix is finishing up the mt76 driver which uses them.)
>>
>> Patches for ath10k are under review since quite some time now (but are
>> not merged yet). The latest re-spin is:
>>
>> http://lists.infradead.org/pipermail/ath10k/2016-March/006923.html
>
> Hi all, on Friday I had a chance to experiment with some of these
> patches, specifically Tim's ath9k patch (to use intermediate queues),
> plus MIchal's patch to use fq_codel with the intermediate queues. I
> didn't attempt any fine tuning; I just slapped them together to see
> what happens. (I tried applying Michal's ath10k patches too, but got
> stuck since they seem to be applied against the upstream v4.4 kernel
> and didn't merge cleanly with the latest mac80211 branch. Maybe I was
> doing something wrong.)
>
> Test setup:
> AP (ath9k) -> 2x2 strong signal -> STA1 (mwifiex)
> -> attenuator (-40 dB) -> 1x1 weak signal -> STA2 (mwifiex)
>
> STA2 generally gets modulation levels around MCS0-2 and STA1 usually
> gets something like MCS12-15.
>
> With or without this patch, results with TCP iperf were fishy - I
> think packet loss patterns were particularly bad and caused 2-second
> TCP retry timeouts occasionally - so I removed TCP from the test and
> switched the UDP iperf instead.
>
> I ran isoping (https://gfiber.googlesource.com/vendor/google/platform/+/master/cmds/isoping.c)
> from the AP to both stations to measure two-way latency during all
> tests. (I used -r2 for two packets/sec in each direction in order not
> to affect the test results too much.)
>
> Overall results:
>
> - Running one iperf at a time, I saw ~45 Mbps to STA1 and ~7 Mbps to STA2.
>
> - Running both iperfs at once, without the patches, latencies got
> extremely high (~600ms sometimes) and results were closer to
> byte-fairness than airtime-fairness (ie. ~7 Mbps each).
>
> - Running both iperfs at once, with the patches, latencies were still
> high (usually high 2-digit, sometimes low 3-digit latencies) but we
> got closer to airtime-fairness than byte-fairness (~17 Mbps and ~2
> Mbps).
>
> - With only one iperf running, without the patches, latencies were
> high to both stations. With the patches, latency was
> mid-double-digits to the non-iperf station (pretty good!) while being
> low-mid triple-digits to the busy iperf station. This suggests that
> we are getting per-station queuing (yay!) but does make me question
> whether the fq_ in fq_codel was working.
Please change the 'if (flow->txqi)' check in ieee80211_txq_enqueue to:
if (flow->txqi && flow->txqi != txqi)
This should hopefully fix the fq_ part ;)
- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-07 15:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 13:09 [RFC/RFT] mac80211: implement fq_codel for software queuing Michal Kazior
[not found] ` <1456492163-11437-1-git-send-email-michal.kazior-++hxYGjEMp0AvxtiuMwx3w@public.gmane.org>
2016-02-26 16:48 ` Felix Fietkau
2016-02-26 18:54 ` Michal Kazior
2016-03-07 23:06 ` Dave Taht
2016-03-08 7:12 ` Michal Kazior
2016-03-08 10:19 ` Toke Høiland-Jørgensen
2016-03-08 13:14 ` Bob Copeland
2016-03-08 13:27 ` Michal Kazior
[not found] ` <CA+BoTQk+3jhwK57_fDw0scNCGzu_Edqp9-Beeppz8xj9kSQcoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-10 18:57 ` Dave Taht
2016-03-11 8:32 ` Michal Kazior
[not found] ` <CAA93jw4XsEnp3jTgPL7OKWTJP-83VwRaCdb+foc8nCuqxk3WZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-08 10:57 ` Michal Kazior
2016-03-01 14:02 ` Johannes Berg
2016-03-02 7:38 ` Michal Kazior
[not found] ` <CA+BoTQkritHYYWA53zb_AcGT4sc92fytQo3CGP6GQouWRift1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-03 17:00 ` Dave Taht
2016-03-04 2:48 ` Tim Shepard
2016-03-04 6:32 ` Michal Kazior
[not found] ` <CA+BoTQk6J7kgdie9aX24MB+8PxN3oFUh0eVdmVrdyptW5RxQXg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-07 14:05 ` Avery Pennarun
[not found] ` <CAPp0ZBYP9UzUTtPz=vivUQkE2FiGSsJjDaecQtPuK8y_d3ccqA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-07 15:09 ` Felix Fietkau [this message]
[not found] ` <56DD99AA.8050403-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2016-03-07 16:25 ` Avery Pennarun
[not found] ` <CAHqTa-2-uZ0PUdwp33E588EU2a7T6KnTYs8RWfNDEzgOLseG9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-07 16:54 ` Dave Taht
[not found] ` <CAA93jw4JG_uEZaxk1JDKndq9K0+QPwKaAmK6=gZ8e-7qNmc=Cw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-07 17:14 ` Avery Pennarun
2016-03-07 17:22 ` Grumbach, Emmanuel
2016-03-07 18:28 ` Dave Taht
[not found] ` <CAA93jw5fvGQ5L7dQupFX4ymhxquswSit1ZiATKmLp4+O4Mwbrw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-08 7:41 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DD99AA.8050403@openwrt.org \
--to=nbd-p3rkhjxn3npafugrpc6u6w@public$(echo .)gmane.org \
--cc=andrewmcgr-hpIqsD4AKlfQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=apenwarr-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=dave.taht-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=emmanuel.grumbach-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=michal.kazior-++hxYGjEMp0AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=shep-FrUbXkNCsVf2fBVCVOL8/A@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox