From: Daniel Borkmann <daniel@iogearbox•net>
To: Tom Herbert <tom@herbertland•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Alexei Starovoitov <alexei.starovoitov@gmail•com>,
Thomas Graf <tgraf@suug•ch>,
Linux Kernel Network Developers <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next 2/4] vxlan: support setting IPv6 flow label
Date: Wed, 09 Mar 2016 11:53:29 +0100 [thread overview]
Message-ID: <56E000A9.9060001@iogearbox.net> (raw)
In-Reply-To: <CALx6S37cKnQwMhjjJBodgNbLb7OQ7qzp76Ubr7BVd11SPznGuA@mail.gmail.com>
On 03/09/2016 04:29 AM, Tom Herbert wrote:
[...]
>> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
>> index d452cea..6bebc97 100644
>> --- a/include/uapi/linux/if_link.h
>> +++ b/include/uapi/linux/if_link.h
>> @@ -456,6 +456,7 @@ enum {
>> IFLA_VXLAN_GBP,
>> IFLA_VXLAN_REMCSUM_NOPARTIAL,
>> IFLA_VXLAN_COLLECT_METADATA,
>> + IFLA_VXLAN_LABEL,
>
> Should this interface align with ip_gre that uses IFLA_GRE_FLOWINFO to
> set both traffic class and flow label in one shot?
For vxlan and geneve by the way, there's already IFLA_VXLAN_TOS and
IFLA_GENEVE_TOS attribute that configure the tos for IPv4 or traffic
class for IPv6 case on the device, and have special handling in the
xmit path that they can inherit the tos/tc when configured as such on
the device in non collect metadata case. Seems like grev6 is handled
differently and also still without tunnel key support, if I see this
correctly. Agree with you that some more consolidation would be nice.
>> __IFLA_VXLAN_MAX
>> };
>> #define IFLA_VXLAN_MAX (__IFLA_VXLAN_MAX - 1)
>> --
>> 1.9.3
next prev parent reply other threads:[~2016-03-09 10:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 2:00 [PATCH net-next 0/4] BPF support for flow labels Daniel Borkmann
2016-03-09 2:00 ` [PATCH net-next 1/4] ip_tunnel: add support for setting flow label via collect metadata Daniel Borkmann
2016-03-09 2:00 ` [PATCH net-next 2/4] vxlan: support setting IPv6 flow label Daniel Borkmann
2016-03-09 3:29 ` Tom Herbert
2016-03-09 10:53 ` Daniel Borkmann [this message]
2016-03-09 2:00 ` [PATCH net-next 3/4] geneve: " Daniel Borkmann
2016-03-09 3:38 ` Tom Herbert
2016-03-09 2:00 ` [PATCH net-next 4/4] bpf: support flow label for bpf_skb_{set,get}_tunnel_key Daniel Borkmann
2016-03-11 20:14 ` [PATCH net-next 0/4] BPF support for flow labels David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E000A9.9060001@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tgraf@suug$(echo .)ch \
--cc=tom@herbertland$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox