From: oulijun <oulijun-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>
To: Sergei Shtylyov
<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public•gmane.org>,
"Wei Hu(Xavier)"
<xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>,
<sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>,
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
<jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>,
<jiri-VPRAkNaXOzVWk0Htik3J/w@public•gmane.org>,
<ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public•gmane.org>
Cc: <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<gongyangming-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<xiaokun-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<tangchaofei-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<haifeng.wei-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<yisen.zhuang-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<yankejian-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<lisheng011-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<charles.chenxin-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
<linuxarm-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>
Subject: Re: [PATCH 2/4] infiniband: hns: add Hisilicon RoCE support(binding)
Date: Wed, 9 Mar 2016 18:56:48 +0800 [thread overview]
Message-ID: <56E00170.2050405@huawei.com> (raw)
In-Reply-To: <56D992E2.3060504-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
Hi Sergei Shtylyov, thanks for reviewing
I have modified the binding referred to your advice and the bindings of other module.
I will send a new patch in future.
Thanks
Lijun Ou
On 2016/3/4 21:51, Sergei Shtylyov wrote:
> Hello.
>
> On 3/4/2016 11:41 AM, Wei Hu(Xavier) wrote:
>
>> This submit add binding file and dts file.
>>
>> Signed-off-by: Wei Hu(Xavier) <xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>
>> Signed-off-by: oulijun <oulijun-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>
>> ---
>> .../bindings/infiniband/hisilicon-hns-roce.txt | 68 ++++++++++++++++++++++
>> 1 file changed, 68 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
>>
>> diff --git a/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
>> new file mode 100644
>> index 0000000..8004641
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
>> @@ -0,0 +1,68 @@
>> +HiSilicon RoCE DT description
>> +
>> +HiSilicon RoCE engine is a part of network subsystem.
>> +It works depending on other part of network wubsytem, such as, gmac and
>> +dsa fabric.
>> +
>> +Additional properties are described here:
>> +
>> +Required properties:
>> +- compatible: Should contain "hisilicon,hns-roce-v1".
>> +- reg: Physical base address of the roce driver and
>> +length of memory mapped region.
>> +- eth-handle: phandle, specifies a reference to a node
>> +representing a ethernet device.
>> +- dsaf-handle: phandle, specifies a reference to a node
>> +representing a dsaf device.
>> +- #address-cells: must be 2
>> +- #size-cells: must be 2
>> +Optional properties:
>> +- dma-coherent: Present if DMA operations are coherent.
>> +- interrupt-parent: the interrupt parent of this device.
>> +- interrupts: should contain 32 completion event irq,1 async event irq
>> +and 1 event overflow irq.
>
> The "interrupt-names" prop is very desirable for so many interrupts.
>
>> +Example:
>> + rocee@0xc4000000 {
>
> The node names should be generic and "0x" should be omitted, i.e. "infiniband@c4000000".
>
> MBR, Sergei
>
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-09 10:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 8:41 [PATCH 0/4] infiniband: hns: Hisilicon RoCE support Wei Hu(Xavier)
2016-03-04 8:41 ` [PATCH 1/4] net: hns: add Hisilicon RoCE support(the dependent routine) Wei Hu(Xavier)
[not found] ` <1457080877-13456-2-git-send-email-xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-03-06 14:25 ` Leon Romanovsky
[not found] ` <20160306142516.GE13396-2ukJVAZIZ/Y@public.gmane.org>
2016-03-09 11:20 ` oulijun
2016-03-04 8:41 ` [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code) Wei Hu(Xavier)
2016-03-04 9:16 ` Jiri Pirko
[not found] ` <20160304091628.GB2150-6KJVSR23iU488b5SBfVpbw@public.gmane.org>
2016-03-09 11:18 ` oulijun
[not found] ` <56E0066E.1000106-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-03-09 11:25 ` Jiri Pirko
2016-03-04 8:41 ` [PATCH 4/4] infiniband: hns: add Hisilicon RoCE support(Kconfig) Wei Hu(Xavier)
2016-03-04 12:10 ` kbuild test robot
[not found] ` <1457080877-13456-5-git-send-email-xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-03-04 12:10 ` [PATCH] infiniband: hns: fix boolreturn.cocci warnings kbuild test robot
2016-03-06 14:29 ` [PATCH 4/4] infiniband: hns: add Hisilicon RoCE support(Kconfig) Leon Romanovsky
2016-03-09 11:23 ` oulijun
2016-03-04 12:10 ` [PATCH] infiniband: hns: fix returnvar.cocci warnings kbuild test robot
2016-03-04 12:10 ` [PATCH] infiniband: hns: fix semicolon.cocci warnings kbuild test robot
[not found] ` <1457080877-13456-1-git-send-email-xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-03-04 8:41 ` [PATCH 2/4] infiniband: hns: add Hisilicon RoCE support(binding) Wei Hu(Xavier)
[not found] ` <1457080877-13456-3-git-send-email-xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-03-04 13:51 ` Sergei Shtylyov
[not found] ` <56D992E2.3060504-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-03-09 10:56 ` oulijun [this message]
2016-03-06 14:19 ` [PATCH 0/4] infiniband: hns: Hisilicon RoCE support Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E00170.2050405@huawei.com \
--to=oulijun-hv44wf8li93qt0dzr+alfa@public$(echo .)gmane.org \
--cc=charles.chenxin-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=gongyangming-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=haifeng.wei-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=jiri-VPRAkNaXOzVWk0Htik3J/w@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linuxarm-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=lisheng011-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public$(echo .)gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public$(echo .)gmane.org \
--cc=tangchaofei-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=xiaokun-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=yankejian-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=yisen.zhuang-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox