From: David Daney <ddaney@caviumnetworks•com>
To: Andrew Lunn <andrew@lunn•ch>
Cc: David Daney <ddaney.cavm@gmail•com>,
"David S. Miller" <davem@davemloft•net>, <netdev@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>,
Florian Fainelli <f.fainelli@gmail•com>,
Robert Richter <rric@kernel•org>,
Sunil Goutham <sgoutham@cavium•com>,
Kumar Gala <galak@codeaurora•org>,
Ian Campbell <ijc+devicetree@hellion•org.uk>,
Mark Rutland <mark.rutland@arm•com>,
Pawel Moll <pawel.moll@arm•com>, Rob Herring <robh+dt@kernel•org>,
Radha Mohan Chintakuntla <rchintakuntla@cavium•com>,
<linux-kernel@vger•kernel.org>,
David Daney <david.daney@cavium•com>
Subject: Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code.
Date: Fri, 11 Mar 2016 09:41:06 -0800 [thread overview]
Message-ID: <56E30332.7060003@caviumnetworks.com> (raw)
In-Reply-To: <20160311173125.GI3153@lunn.ch>
On 03/11/2016 09:31 AM, Andrew Lunn wrote:
>> + phy_np = of_parse_phandle(node, "phy-handle", 0);
>> + /* If there is no phy or defective firmware presents
>> + * this cortina phy, for which there is no driver
>> + * support, ignore it.
>> + */
>> + if (phy_np &&
>> + !of_device_is_compatible(phy_np, "cortina,cs4223-slice")) {
>
> Hi David
>
> What is a cortina,cs4223-slice,
It is 1/4 of:
https://www.inphi.com/products/cs4223.php
> and why does it need to be handled differently?
>
$ ls drivers/net/phy/*cortina*
ls: cannot access drivers/net/phy/*cortina*: No such file or directory
For this configuration of thunder_bgx.c, the use of a Linux PHY driver
is optional.
The firmware should probably not specify a PHY here, but it does so we
ignore it so we don't wait around forever for the non-existent driver to
bind.
next prev parent reply other threads:[~2016-03-11 17:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 16:46 [PATCH 0/3] net/phy: Improvements to Cavium Thunder MDIO code David Daney
2016-03-11 16:47 ` [PATCH 1/3] net: thunderx: Cleanup PHY probing code David Daney
2016-03-11 17:31 ` Andrew Lunn
2016-03-11 17:41 ` David Daney [this message]
2016-03-11 18:00 ` Andrew Lunn
2016-03-11 18:26 ` David Daney
2016-03-11 19:06 ` Andrew Lunn
2016-03-11 19:34 ` David Daney
2016-03-11 19:37 ` Florian Fainelli
2016-03-11 20:56 ` David Daney
2016-03-11 21:35 ` Andrew Lunn
2016-03-11 21:57 ` David Daney
2016-03-11 16:47 ` [PATCH 2/3] phy: mdio-octeon: Refactor into two files/modules David Daney
2016-03-11 16:47 ` [PATCH 3/3] phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E30332.7060003@caviumnetworks.com \
--to=ddaney@caviumnetworks$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=david.daney@cavium$(echo .)com \
--cc=ddaney.cavm@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=galak@codeaurora$(echo .)org \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pawel.moll@arm$(echo .)com \
--cc=rchintakuntla@cavium$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=rric@kernel$(echo .)org \
--cc=sgoutham@cavium$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox