From: Edward Cree <ecree@solarflare•com>
To: Tom Herbert <tom@herbertland•com>
Cc: Linux Kernel Network Developers <netdev@vger•kernel.org>
Subject: Re: Generic TSO (was Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default)
Date: Fri, 11 Mar 2016 19:59:23 +0000 [thread overview]
Message-ID: <56E3239B.7080009@solarflare.com> (raw)
In-Reply-To: <CALx6S37G5N-3GxXYf8uF9p8QNC+U_d6-Vf+8Jg6bFqEv_FpULg@mail.gmail.com>
On 11/03/16 19:57, Tom Herbert wrote:
> On Fri, Mar 11, 2016 at 11:20 AM, Edward Cree <ecree@solarflare•com> wrote:
>> Tom,
>>
>> Are you planning to / working on implementing this? If not, I might have a
>> crack at it; I've talked to our firmware guys and (provisionally) we think
>> we can support it in current sfc hardware.
>> Or were there any blocking problems raised in the thread? My understanding
>> of the IP ID issue was that it only matters for the inner frame, because
>> the rest aren't TCP (so hopefully no-one is doing SLHC on them). But I may
>> have missed something.
>>
> Right, then the interface would need to just include the offset of the
> IP ID. But doesn't this break using LCO with GSO though-- i.e. the
> outer checksum and inner checksum still need to be updated per packet
> so we need to tell device where outer checksum(s) is.
No, outer checksum shouldn't change: IP ID is protected by inner IP header
checksum, which device will edit. No?
-Ed
next prev parent reply other threads:[~2016-03-11 20:12 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 19:26 [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default Alexander Duyck
2016-02-19 19:26 ` [net-next PATCH 1/2] GENEVE: Support outer IPv4 Tx checksums " Alexander Duyck
2016-02-19 20:28 ` Tom Herbert
2016-02-19 19:26 ` [net-next PATCH 2/2] VXLAN: " Alexander Duyck
2016-02-19 20:27 ` Tom Herbert
2016-02-19 21:36 ` Jesse Gross
2016-02-19 21:53 ` [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum " Jesse Gross
2016-02-19 23:10 ` Alex Duyck
2016-02-20 0:08 ` Jesse Gross
2016-02-20 0:14 ` Tom Herbert
2016-02-20 2:18 ` Jesse Gross
2016-02-20 19:51 ` Tom Herbert
2016-02-23 3:31 ` Jesse Gross
2016-02-23 15:18 ` Edward Cree
2016-02-23 16:47 ` Tom Herbert
2016-02-23 17:20 ` Rick Jones
2016-02-23 17:38 ` Edward Cree
2016-02-23 18:08 ` David Miller
2016-02-23 20:20 ` Edward Cree
2016-02-23 23:11 ` David Miller
2016-02-24 0:53 ` Tom Herbert
2016-02-24 17:30 ` Edward Cree
2016-02-23 18:11 ` Tom Herbert
2016-02-23 17:31 ` Jesse Gross
2016-02-23 17:42 ` Tom Herbert
2016-02-23 18:18 ` Alexander Duyck
2016-02-23 18:26 ` David Miller
2016-02-23 18:32 ` Tom Herbert
2016-02-23 18:24 ` David Miller
2016-02-24 9:58 ` David Laight
2016-02-24 15:41 ` David Miller
2016-02-25 20:14 ` David Miller
2016-03-11 19:20 ` Generic TSO (was Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default) Edward Cree
2016-03-11 19:57 ` Tom Herbert
2016-03-11 19:59 ` Edward Cree [this message]
2016-03-11 20:16 ` Tom Herbert
2016-03-11 20:24 ` Edward Cree
2016-03-11 21:09 ` Alexander Duyck
2016-03-11 21:29 ` Edward Cree
2016-03-11 22:31 ` Alexander Duyck
2016-03-11 22:55 ` Tom Herbert
2016-03-12 5:40 ` Alexander Duyck
2016-03-14 10:26 ` Generic TSO Edward Cree
2016-03-14 10:32 ` Edward Cree
2016-03-14 15:59 ` Alexander Duyck
2016-03-11 20:22 ` David Miller
2016-02-22 3:06 ` [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E3239B.7080009@solarflare.com \
--to=ecree@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tom@herbertland$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox