From: Daode Huang <huangdaode@hisilicon•com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>,
<davem@davemloft•net>
Cc: <liguozhu@hisilicon•com>, <Yisen.Zhuang@huawei•com>,
<linux-kernel@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>, <netdev@vger•kernel.org>,
<linuxarm@huawei•com>, <salil.mehta@huawei•com>,
<kenneth-lee-2012@foxmail•com>, <xuwei5@hisilicon•com>,
<lisheng011@huawei•com>, <yankejian@huawei•com>
Subject: Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt
Date: Mon, 14 Mar 2016 08:45:13 +0800 [thread overview]
Message-ID: <56E60999.90703@hisilicon.com> (raw)
In-Reply-To: <56E2C839.4000700@cogentembedded.com>
On 2016/3/11 21:29, Sergei Shtylyov wrote:
> Hello.
>
> On 3/11/2016 4:53 AM, Daode Huang wrote:
>
>>>> In V2 chip, when sending mamagement packets, the driver should
>>>> config the port id to BD descs.
>>>>
>>>> Signed-off-by: Daode Huang <huangdaode@hisilicon•com>
>>>> Signed-off-by: Lisheng <lisheng011@huawei•com>
>>>> ---
>>>> drivers/net/ethernet/hisilicon/hns/hnae.h | 3 +++
>>>> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 1 +
>>>> drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++++
>>>> 3 files changed, 8 insertions(+)
>>>>
>>>> diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.h
>>>> b/drivers/net/ethernet/hisilicon/hns/hnae.h
>>>> index 1cbcb9f..11a3f97 100644
>>>> --- a/drivers/net/ethernet/hisilicon/hns/hnae.h
>>>> +++ b/drivers/net/ethernet/hisilicon/hns/hnae.h
>>> [...]
>>>> @@ -516,6 +518,7 @@ struct hnae_handle {
>>>> int q_num;
>>>> int vf_id;
>>>> u32 eport_id;
>>>> + u32 dport_id; /*v2 tx bd should fill the dport_id*/
>>>
>>> Please add spaces after /* and before */ (like it's done in other
>>> places
>>> in this driver).
>>>
>>
>> Hi MBR, Sergei,
>
> Just in case: MBR stands for "my best regards", Sergei is my name. :-)
hi Sergei,
So sorry for my misunderstanding.
thanks for your reminding.
Best Regards
Daode.
>
>> Daode.
>
> MBR, Sergei
>
>
> .
>
next prev parent reply other threads:[~2016-03-14 0:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 1:09 [PATCH net 0/6]net: hns: hns driver updates Daode Huang
2016-03-04 0:55 ` Daode Huang
2016-03-04 1:09 ` [PATCH net 1/6] net: hns: bug fix about the overflow of mss Daode Huang
2016-03-04 1:09 ` [PATCH net 2/6] net: hns: fixes the hw interrupt bug in using napi Daode Huang
2016-03-04 1:09 ` [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt Daode Huang
2016-03-04 13:37 ` Sergei Shtylyov
2016-03-11 1:53 ` Daode Huang
2016-03-11 13:29 ` Sergei Shtylyov
2016-03-14 0:45 ` Daode Huang [this message]
2016-03-04 1:09 ` [PATCH net 4/6] net: hns: adds uc match for debug port Daode Huang
2016-03-04 13:39 ` Sergei Shtylyov
2016-03-11 1:58 ` Daode Huang
2016-03-04 1:09 ` [PATCH net 5/6] net: hns: fixed service-ges setting MAC-addr bug Daode Huang
2016-03-04 1:09 ` [PATCH net 6/6] net: hns: bug fix of getting hilink status Daode Huang
-- strict thread matches above, loose matches on Subject: below --
2016-03-04 3:05 [PATCH net 0/6]net: hns: hns driver updates Daode Huang
2016-03-04 3:05 ` [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt Daode Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E60999.90703@hisilicon.com \
--to=huangdaode@hisilicon$(echo .)com \
--cc=Yisen.Zhuang@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kenneth-lee-2012@foxmail$(echo .)com \
--cc=liguozhu@hisilicon$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxarm@huawei$(echo .)com \
--cc=lisheng011@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=salil.mehta@huawei$(echo .)com \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=xuwei5@hisilicon$(echo .)com \
--cc=yankejian@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox