From: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
To: Gabriel Fernandez <gabriel.fernandez@linaro•org>
Cc: netdev@vger•kernel.org, "Andreas Färber" <afaerber@suse•de>,
fschaefer.oss@googlemail•com,
"Dinh Nguyen" <dinh.linux@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
"Phil Reid" <preid@electromag•com.au>
Subject: Re: [PATCHv3 (net.git) 2/2] stmmac: fix MDIO settings
Date: Mon, 14 Mar 2016 10:28:14 +0100 [thread overview]
Message-ID: <56E6842E.1040103@st.com> (raw)
In-Reply-To: <CAG374jDMk3z0rn-eMfRWiw7FUvN_26yjsVc340zvQPFq=XxuLg@mail.gmail.com>
On 3/14/2016 10:14 AM, Gabriel Fernandez wrote:
> Hi Peppe,
>
> Just one remark below
>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> index 6a52fa1..d2322e9 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>
> [snip]
>
>> +static bool stmmac_dt_phy(struct plat_stmmacenet_data *plat,
>> + struct device_node *np, struct device *dev)
>> +{
>> + bool ret = true;
>> +
>> + /* If phy-handle property is passed from DT, use it as the PHY */
>> + plat->phy_node = of_parse_phandle(np, "phy-handle", 0);
>> + if (plat->phy_node)
>> + dev_dbg(dev, "Found phy-handle subnode\n");
>> +
>> + /* If phy-handle is not specified, check if we have a fixed-phy */
>> + if (!plat->phy_node && of_phy_is_fixed_link(np)) {
>> + if ((of_phy_register_fixed_link(np) < 0))
>> + return -ENODEV;
>> +
> stmmac_dt_phy() function should return a Boolean
Thx Gabriel, I will fix return value in V4.
peppe
>
>
> Best Regards.
>
> Gabriel
>
>
next prev parent reply other threads:[~2016-03-14 9:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 13:33 [PATCHv3 (net.git) 0/2] stmmac: MDIO fixes Giuseppe Cavallaro
2016-03-11 13:33 ` [PATCH v3(linux-sti-3.10)(net.git) 1/2] Revert "stmmac: Fix 'eth0: No PHY found' regression" Giuseppe Cavallaro
2016-03-11 13:33 ` [PATCHv3 (net.git) 2/2] stmmac: fix MDIO settings Giuseppe Cavallaro
2016-03-11 15:14 ` Phil Reid
2016-03-11 15:32 ` Giuseppe CAVALLARO
2016-03-14 0:50 ` Phil Reid
2016-03-12 10:50 ` Frank Schäfer
2016-03-14 9:14 ` Gabriel Fernandez
2016-03-14 9:28 ` Giuseppe CAVALLARO [this message]
2016-03-15 0:54 ` Andreas Färber
2016-03-15 15:53 ` Giuseppe CAVALLARO
2016-03-16 9:47 ` Andreas Färber
2016-03-16 10:18 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E6842E.1040103@st.com \
--to=peppe.cavallaro@st$(echo .)com \
--cc=afaerber@suse$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=dinh.linux@gmail$(echo .)com \
--cc=fschaefer.oss@googlemail$(echo .)com \
--cc=gabriel.fernandez@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=preid@electromag$(echo .)com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox